Merge pull request #197 from ellenhp/ellenhp/transit_bugfixes

Sort itineraries by earliest arrival, search sheet fixes

Author: ellenhp

cardinal-android/app/src/main/java/earth/maps/cardinal/routing/RoutingOptions.kt

@@ -29,6 +29,7 @@ abstract class RoutingOptions {
     /**
      * Convert this options object to JSON string for Valhalla API.
      */
+    @Suppress("unused")
     fun toValhallaOptionsJson(): String {
         val gson = GsonBuilder().setFieldNamingPolicy(FieldNamingPolicy.LOWER_CASE_WITH_UNDERSCORES)
             .create()

cardinal-android/app/src/main/java/earth/maps/cardinal/ui/core/AppContent.kt

@@ -989,7 +989,6 @@ private fun HomeScreenComposable(
                         onPeekHeightChange(it)
                     }
                 },
-                homeInSearchScreen = searchExpanded == true,
                 onSearchFocusChange = {
                     if (it) {
                         viewModel.expandSearch()

cardinal-android/app/src/main/java/earth/maps/cardinal/ui/directions/TransitDirectionsScreen.kt

@@ -112,7 +112,7 @@ private fun TransitTimelineResults(
 ) {
     LazyColumn(modifier = modifier) {
         items(planResponse.itineraries.size) { index ->
-            val itinerary = planResponse.itineraries[index]
+            val itinerary = planResponse.itineraries.reversed()[index]
 
             TransitItineraryCard(
                 itinerary = itinerary,

cardinal-android/app/src/main/java/earth/maps/cardinal/ui/home/HomeScreen.kt

@@ -84,7 +84,6 @@ fun HomeScreen(
     onPlaceSelected: (Place) -> Unit,
     onPeekHeightChange: (dp: Dp) -> Unit,
     onSearchFocusChange: (Boolean) -> Unit,
-    homeInSearchScreen: Boolean,
 ) {
     val searchQuery = viewModel.searchQuery
 
@@ -98,7 +97,7 @@ fun HomeScreen(
             onSearchFocusChange = onSearchFocusChange,
             onPeekHeightChange = onPeekHeightChange,
             onPlaceSelected = onPlaceSelected,
-            homeInSearchScreen = homeInSearchScreen,
+            homeInSearchScreen = viewModel.searchQuery.text.isNotEmpty(),
         )
     }
 }