Merge pull request #194 from ellenhp/ellenhp/fix_dl_failure_status

ellenhp · web-flow · commit 8626709b7664 · 2025-09-28T18:49:02.000-07:00
Offline map downloads show completed when no failures occur
diff --git a/cardinal-android/app/src/main/java/earth/maps/cardinal/tileserver/TileDownloadForegroundService.kt b/cardinal-android/app/src/main/java/earth/maps/cardinal/tileserver/TileDownloadForegroundService.kt
@@ -372,7 +372,7 @@ class TileDownloadForegroundService : Service() {
 
             } catch (e: Exception) {
                 Log.e(TAG, "Error during download", e)
-            } finally {
+                // Handle download failure
                 handleDownloadCompletion(areaId, false, 0L)
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -372,7 +372,7 @@ class TileDownloadForegroundService : Service() {`
`372`	`372`
`373`	`373`	`} catch (e: Exception) {`
`374`	`374`	`Log.e(TAG, "Error during download", e)`
`375`		`- } finally {`
	`375`	`+ // Handle download failure`
`376`	`376`	`handleDownloadCompletion(areaId, false, 0L)`
`377`	`377`	`}`
`378`	`378`	`}`