Skip to content

Commit 0e14dc0

Browse files
committed
elli_example_websocket: cosmetic tweaks
1 parent 843734f commit 0e14dc0

File tree

1 file changed

+25
-29
lines changed

1 file changed

+25
-29
lines changed

src/elli_example_websocket.erl

Lines changed: 25 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -3,18 +3,18 @@
33

44
-export([init/2, handle/2, handle_event/3]).
55

6-
% Websocket callbacks.
6+
%% Websocket callbacks.
77
-export([
8-
websocket_init/2,
9-
websocket_info/3,
10-
websocket_handle/3,
8+
websocket_init/2,
9+
websocket_info/3,
10+
websocket_handle/3,
1111

12-
websocket_handle_event/3
13-
]).
12+
websocket_handle_event/3
13+
]).
1414

1515
-include_lib("elli/include/elli.hrl").
1616

17-
%% Serves as elli and websocket handler in one module.
17+
%% Serves as elli and websocket handler in one module.
1818

1919
-behaviour(elli_handler).
2020
-behaviour(elli_websocket_handler).
@@ -27,20 +27,20 @@
2727
%% that this request is upgraded.
2828
%%
2929
init(Req, Args) ->
30-
Method = case elli_request:get_header(<<"Upgrade">>, Req) of
31-
<<"websocket">> ->
32-
init_ws(elli_request:path(Req), Req, Args);
33-
_ ->
34-
ignore
35-
end.
30+
_Method = case elli_request:get_header(<<"Upgrade">>, Req) of
31+
<<"websocket">> ->
32+
init_ws(elli_request:path(Req), Req, Args);
33+
_ ->
34+
ignore
35+
end.
3636

3737
handle(Req, Args) ->
3838
Method = case elli_request:get_header(<<"Upgrade">>, Req) of
39-
<<"websocket">> ->
40-
websocket;
41-
_ ->
42-
elli_request:method(Req)
43-
end,
39+
<<"websocket">> ->
40+
websocket;
41+
_ ->
42+
elli_request:method(Req)
43+
end,
4444
handle(Method, elli_request:path(Req), Req, Args).
4545

4646

@@ -60,7 +60,7 @@ handle('websocket', [<<"my">>, <<"websocket">>], Req, Args) ->
6060
handle('GET', [<<"my">>, <<"websocket">>], _Req, _Args) ->
6161
{200, [], <<"Use an upgrade request">>};
6262

63-
handle(_,_,_,_) ->
63+
handle(_, _, _, _) ->
6464
ignore.
6565

6666
handle_event(Name, EventArgs, ElliArgs) ->
@@ -72,24 +72,24 @@ handle_event(Name, EventArgs, ElliArgs) ->
7272
%%
7373

7474

75-
% @doc
76-
%
75+
%% @doc
76+
%%
7777
websocket_init(Req, Opts) ->
7878
io:fwrite(standard_error, "example_ws_init: ~p, ~p ~n", [Req, Opts]),
7979
State = undefined,
8080
{ok, [], State}.
8181

82-
websocket_info(Req, Message, State) ->
82+
websocket_info(_Req, Message, State) ->
8383
io:fwrite(standard_error, "example_ws_info: ~p~n", [Message]),
8484
{ok, State}.
8585

86-
websocket_handle(Req, Message, State) ->
86+
websocket_handle(_Req, Message, State) ->
8787
io:fwrite(standard_error, "example_ws_handle: ~p~n", [Message]),
88-
%% default behaviour.
88+
%% default behaviour.
8989
{ok, State}.
9090
%% comment the line above ({ok, State}.)
9191
%% and uncomment the line below for an echo server.
92-
% {reply, Message, State}.
92+
%% {reply, Message, State}.
9393

9494

9595
%%
@@ -108,7 +108,3 @@ websocket_handle_event(websocket_close, [_, _Reason], _) -> ok;
108108
websocket_handle_event(websocket_throw, [_Request, _Exception, _Stacktrace], _) -> ok;
109109
websocket_handle_event(websocket_error, [_Request, _Exception, _Stacktrace], _) -> ok;
110110
websocket_handle_event(websocket_exit, [_Request, _Exception, _Stacktrace], _) -> ok.
111-
112-
113-
114-

0 commit comments

Comments
 (0)