Fixes for ansible-lint violations

* Update molecule.yml to tolerate larger boot time for Majove image
* Address latest ansible-lint complaints
* Update dependencies (some to address known vulnerabilities)

Author: elliotweiser

molecule/default/molecule.yml

@@ -13,9 +13,10 @@ platforms:
     box_version: "${MOLECULE_BOX_VERSION}"
     memory: 2048
     cpus: 4
+    instance_raw_config_args:
+      - "vm.boot_timeout = 600"
     config_options:
       synced_folder: false
-      boot_timeout: 300
 provisioner:
   name: ansible
   playbooks:

tasks/main.yml

@@ -40,13 +40,16 @@
 
 - name: Check for Command Line Tools in Software Update list
   shell: >
+    set -o pipefail;
     softwareupdate -l |
     grep -B 1 -E 'Command Line Tools' |
     awk -F'*' '/^ +\*/ {print $2}' |
     sed 's/^ *//' |
     grep -iE '[0-9|.]' |
     sort |
     tail -n1
+  args:
+    executable: /bin/bash
   register: su_list
   when: pkg_info.rc != 0 or compiler.rc != 0 or not clt.stat.exists
   changed_when: false

tests/test-requirements.txt

@@ -1,59 +1,61 @@
-ansible==2.7.2
-ansible-lint==3.4.23
+ansible==2.7.7
+ansible-lint==4.1.0
 anyconfig==0.9.7
-arrow==0.12.1
+arrow==0.13.1
 asn1crypto==0.24.0
-atomicwrites==1.2.1
+atomicwrites==1.3.0
 attrs==18.2.0
 backports.functools-lru-cache==1.5
-bcrypt==3.1.4
+bcrypt==3.1.6
 binaryornot==0.4.4
 Cerberus==1.2
-certifi==2018.10.15
-cffi==1.11.5
+certifi==2018.11.29
+cffi==1.12.1
 chardet==3.0.4
 click==6.7
 click-completion==0.3.1
 colorama==0.3.9
-configparser==3.5.0
+configparser==3.7.1
 cookiecutter==1.6.0
-cryptography==2.4.2
+cryptography==2.5
 enum34==1.1.6
 fasteners==0.14.1
 flake8==3.5.0
 funcsigs==1.0.2
 future==0.17.1
-git-url-parse==1.1.0
-idna==2.7
+git-url-parse==1.2.0
+idna==2.8
 ipaddress==1.0.22
 Jinja2==2.10
 jinja2-time==0.2.0
 MarkupSafe==1.1.0
 mccabe==0.6.1
 molecule==2.19.0
 monotonic==1.5
-more-itertools==4.3.0
+more-itertools==5.0.0
 paramiko==2.4.2
-pathlib2==2.3.2
+pathlib2==2.3.3
 pathspec==0.5.9
 pbr==4.1.0
 pexpect==4.6.0
-pluggy==0.8.0
+pluggy==0.8.1
 poyo==0.4.2
 psutil==5.4.6
 ptyprocess==0.6.0
 py==1.7.0
-pyasn1==0.4.4
+pyasn1==0.4.5
 pycodestyle==2.3.1
 pycparser==2.19
 pyflakes==1.6.0
 PyNaCl==1.3.0
-pytest==4.0.1
-python-dateutil==2.7.5
+pytest==4.2.1
+python-dateutil==2.8.0
 python-gilt==1.2.1
 python-vagrant==0.5.15
-PyYAML==3.13
-requests==2.20.1
+PyYAML==4.2b4
+requests==2.21.0
+ruamel.ordereddict==0.4.13
+ruamel.yaml==0.15.88
 scandir==1.9.0
 sh==1.12.14
 six==1.11.0
@@ -62,4 +64,4 @@ testinfra==1.16.0
 tree-format==0.1.2
 urllib3==1.24.1
 whichcraft==0.5.2
-yamllint==1.11.1
+yamllint==1.15.0