Skip to content

Added fill placeholders function #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added fill placeholders function #35

wants to merge 1 commit into from

Conversation

albertdahlin
Copy link

I have found this function quite useful for me, maybe it could be useful for others?

Maybe there is a better name for it?

fillPlaceholders
        [ ( "page", "2" )
        , ( "total", "100" )
        ]
        "Page {{ page }} of {{ total }}"

will result in "Page 2 of 100"

@jaapz
Copy link
Collaborator

jaapz commented Dec 3, 2018

Looks useful to me, especially when working with translated strings. Would be nice to have some tests, though!

@albertdahlin
Copy link
Author

I will be happy to write some tests. Are you using the tests in /tests dir? I thought they were all 0.18 but maybe that does not matter?

@jaapz
Copy link
Collaborator

jaapz commented Apr 10, 2019

Honestly I'm not sure what the status of the tests is currently. I'll have to take a look but I'm short on time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@albertdahlin @jaapz