Update elm-review (#96)

* Update elm-review
* Apply elm-review fixes

Author: miniBill

package-lock.json

@@ -3,7 +3,7 @@
     "elm": "0.19.1-5",
     "elm-doc-preview": "^5.0.5",
     "elm-format": "^0.8.7",
-    "elm-review": "^2.13.0",
+    "elm-review": "^2.13.5",
     "elm-test": "0.19.1-revision12",
     "elm-verify-examples": "^6.0.3",
     "npm-run-all": "^4.1.5"

package.json

@@ -7,27 +7,27 @@
     "dependencies": {
         "direct": {
             "elm/core": "1.0.5",
-            "elm/json": "1.1.3",
+            "elm/json": "1.1.4",
             "elm/project-metadata-utils": "1.0.2",
-            "jfmengels/elm-review": "2.15.0",
+            "jfmengels/elm-review": "2.16.6",
             "jfmengels/elm-review-code-style": "1.2.0",
-            "jfmengels/elm-review-common": "1.3.3",
+            "jfmengels/elm-review-common": "1.3.5",
             "jfmengels/elm-review-debug": "1.0.8",
             "jfmengels/elm-review-documentation": "2.0.4",
             "jfmengels/elm-review-performance": "1.0.2",
-            "jfmengels/elm-review-simplify": "2.1.6",
-            "jfmengels/elm-review-unused": "1.2.4",
-            "stil4m/elm-syntax": "7.3.8"
+            "jfmengels/elm-review-simplify": "2.1.15",
+            "jfmengels/elm-review-unused": "1.2.6",
+            "stil4m/elm-syntax": "7.3.9"
         },
         "indirect": {
             "elm/bytes": "1.0.8",
-            "elm/html": "1.0.0",
+            "elm/html": "1.0.1",
             "elm/parser": "1.1.0",
             "elm/random": "1.0.0",
             "elm/regex": "1.0.0",
             "elm/time": "1.0.0",
-            "elm/virtual-dom": "1.0.3",
-            "elm-explorations/test": "2.2.0",
+            "elm/virtual-dom": "1.0.5",
+            "elm-explorations/test": "2.2.1",
             "pzp1997/assoc-list": "1.0.0",
             "rtfeldman/elm-hex": "1.0.0",
             "stil4m/structured-writer": "1.0.3"

review/elm.json

@@ -69,8 +69,6 @@ Functions borrowed from the Rails Inflector class
 
 import Array
 import Char exposing (toLower, toUpper)
-import List
-import Maybe exposing (Maybe(..))
 import Regex exposing (Regex)
 import String exposing (cons, uncons)
 import String.Diacritics as Diacritics
@@ -565,7 +563,7 @@ unindent multilineSting =
 -}
 countOccurrences : String -> String -> Int
 countOccurrences needle haystack =
-    if String.length needle == 0 || String.length haystack == 0 then
+    if String.isEmpty needle || String.isEmpty haystack then
         0
 
     else

src/String/Extra.elm

@@ -303,14 +303,14 @@ suite =
         , Test.describe "sliceFrom"
             [ test "index positive valid"
                 (\() ->
-                    Array.fromList (List.range 0 6)
+                    Array.initialize 7 identity
                         |> Array.sliceFrom 3
                         |> expectEqualArrays
                             (Array.fromList [ 3, 4, 5, 6 ])
                 )
             , test "index negative valid"
                 (\() ->
-                    Array.fromList (List.range 0 6)
+                    Array.initialize 7 identity
                         |> Array.sliceFrom -3
                         |> expectEqualArrays
                             (Array.fromList [ 4, 5, 6 ])
@@ -345,14 +345,14 @@ suite =
         , Test.describe "sliceUntil"
             [ test "index positive valid"
                 (\() ->
-                    Array.fromList (List.range 0 6)
+                    Array.initialize 7 identity
                         |> Array.sliceUntil 3
                         |> expectEqualArrays
                             (Array.fromList [ 0, 1, 2 ])
                 )
             , test "index negative valid"
                 (\() ->
-                    Array.fromList (List.range 0 6)
+                    Array.initialize 7 identity
                         |> Array.sliceUntil -3
                         |> expectEqualArrays
                             (Array.fromList [ 0, 1, 2, 3 ])

tests/ArrayTests.elm

@@ -1,4 +1,4 @@
-module OrderTests exposing (Card, Point, Suite(..), Value(..), all)
+module OrderTests exposing (Card, Point, Suite, Value, all)
 
 import Dict
 import Expect

tests/OrderTests.elm

@@ -1,6 +1,5 @@
 module String.ClassifyTest exposing (classifyTest)
 
-import Char
 import Expect
 import Fuzz exposing (Fuzzer)
 import Regex

tests/String/ClassifyTest.elm

@@ -1,10 +1,8 @@
 module String.HumanizeTest exposing (humanizeTest)
 
-import Char
 import Expect
 import Fuzz exposing (Fuzzer)
 import Regex
-import String
 import String.Extra exposing (humanize)
 import String.TestData as TestData
 import Test exposing (Test, describe, fuzz, test)

tests/String/HumanizeTest.elm

@@ -2,7 +2,6 @@ module String.ReplaceSliceTest exposing (replaceSliceTest)
 
 import Expect
 import Fuzz exposing (Fuzzer)
-import String
 import String.Extra
 import Test exposing (Test, describe, fuzz)
 

tests/String/ReplaceSliceTest.elm

@@ -68,7 +68,7 @@ decapitalizeTest =
             \string ->
                 let
                     result =
-                        (String.Extra.decapitalize >> tail) string
+                        tail <| String.Extra.decapitalize string
 
                     expected =
                         tail string
@@ -118,7 +118,7 @@ breakTest =
                     _ ->
                         String.Extra.break width string
                             |> List.length
-                            |> Expect.equal (ceiling <| (toFloat << String.length) string / toFloat width)
+                            |> Expect.equal (ceiling <| (toFloat <| String.length string) / toFloat width)
         , fuzz2 Fuzz.string (Fuzz.intRange 1 10) "Concatenating the result yields the original string" <|
             \string width ->
                 String.Extra.break width string
@@ -128,9 +128,8 @@ breakTest =
             \string width ->
                 String.Extra.break width string
                     |> List.map String.length
-                    |> List.filter (\x -> width < x)
-                    |> List.isEmpty
-                    |> Expect.equal True
+                    |> List.any (\x -> width < x)
+                    |> Expect.equal False
                     |> Expect.onFail "The list has some long elements"
         ]