Merge pull request kubernetes#3191 from marwanad/run-hack-verify-all

fix gofmt and lint issues

Author: k8s-ci-robot

cluster-autoscaler/cloudprovider/azure/azure_manager.go

@@ -66,12 +66,12 @@ const (
 	backoffJitterDefault   = 1.0
 
 	// rate limit
-	rateLimitQPSDefault float32 = 1.0
-	rateLimitBucketDefault = 5
-	rateLimitReadQPSEnvVar = "RATE_LIMIT_READ_QPS"
-	rateLimitReadBucketsEnvVar = "RATE_LIMIT_READ_BUCKETS"
-	rateLimitWriteQPSEnvVar = "RATE_LIMIT_WRITE_QPS"
-	rateLimitWriteBucketsEnvVar = "RATE_LIMIT_WRITE_BUCKETS"
+	rateLimitQPSDefault         float32 = 1.0
+	rateLimitBucketDefault              = 5
+	rateLimitReadQPSEnvVar              = "RATE_LIMIT_READ_QPS"
+	rateLimitReadBucketsEnvVar          = "RATE_LIMIT_READ_BUCKETS"
+	rateLimitWriteQPSEnvVar             = "RATE_LIMIT_WRITE_QPS"
+	rateLimitWriteBucketsEnvVar         = "RATE_LIMIT_WRITE_BUCKETS"
 )
 
 var validLabelAutoDiscovererKeys = strings.Join([]string{
@@ -402,7 +402,7 @@ func CreateAzureManager(configReader io.Reader, discoveryOpts cloudprovider.Node
 
 	err = InitializeCloudProviderRateLimitConfig(&cfg.CloudProviderRateLimitConfig)
 	if err != nil {
-		return  nil, err
+		return nil, err
 	}
 
 	// Defaulting vmType to vmss.

cluster-autoscaler/cloudprovider/azure/azure_manager_test.go

@@ -434,7 +434,7 @@ func TestInitializeCloudProviderRateLimitConfigWithReadAndWriteRateLimitAlreadyS
 	var rateLimitWriteQPS float32 = 6.0
 	rateLimitWriteBuckets := 20
 
-	configWithRateLimits :=	&CloudProviderRateLimitConfig{
+	configWithRateLimits := &CloudProviderRateLimitConfig{
 		RateLimitConfig: azclients.RateLimitConfig{
 			CloudProviderRateLimitBucket:      rateLimitReadBuckets,
 			CloudProviderRateLimitBucketWrite: rateLimitWriteBuckets,

cluster-autoscaler/cloudprovider/gce/cache.go

@@ -383,7 +383,7 @@ func (gc *GceCache) AddMachineToCache(machineType string, zone string, machine *
 	gc.machinesCache[MachineTypeKey{zone, machineType}] = machinesCacheValue{machineType: machine}
 }
 
-// AddMachineToCache adds machine to cache under lock.
+// AddMachineToCacheWithError adds machine to cache under lock.
 func (gc *GceCache) AddMachineToCacheWithError(machineType string, zone string, err error) {
 	gc.cacheMutex.Lock()
 	defer gc.cacheMutex.Unlock()

cluster-autoscaler/cloudprovider/gce/cache_test.go

@@ -1,3 +1,19 @@
+/*
+Copyright 2020 The Kubernetes Authors.
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
 package gce
 
 import (
@@ -53,7 +69,7 @@ func TestMachineCache(t *testing.T) {
 				},
 			},
 			want: map[MachineTypeKey]uint64{
-				MachineTypeKey{
+				{
 					MachineType: "e2-standard-2",
 					Zone:        "myzone",
 				}: 2,

cluster-autoscaler/cloudprovider/gce/gce_manager_test.go

@@ -337,9 +337,9 @@ func newTestGceManager(t *testing.T, testServerURL string, regional bool) *gceMa
 		instanceRefToMigRef:      make(map[GceRef]GceRef),
 		instancesFromUnknownMigs: make(map[GceRef]struct{}),
 		machinesCache: map[MachineTypeKey]machinesCacheValue{
-			{"us-central1-b", "n1-standard-1"}: machinesCacheValue{&gce.MachineType{GuestCpus: 1, MemoryMb: 1}, nil},
-			{"us-central1-c", "n1-standard-1"}: machinesCacheValue{&gce.MachineType{GuestCpus: 1, MemoryMb: 1}, nil},
-			{"us-central1-f", "n1-standard-1"}: machinesCacheValue{&gce.MachineType{GuestCpus: 1, MemoryMb: 1}, nil},
+			{"us-central1-b", "n1-standard-1"}: {&gce.MachineType{GuestCpus: 1, MemoryMb: 1}, nil},
+			{"us-central1-c", "n1-standard-1"}: {&gce.MachineType{GuestCpus: 1, MemoryMb: 1}, nil},
+			{"us-central1-f", "n1-standard-1"}: {&gce.MachineType{GuestCpus: 1, MemoryMb: 1}, nil},
 		},
 		migTargetSizeCache:     map[GceRef]int64{},
 		instanceTemplatesCache: map[GceRef]*gce.InstanceTemplate{},

vertical-pod-autoscaler/pkg/utils/metrics/metrics.go

@@ -41,7 +41,7 @@ const (
 	// TopMetricsNamespace is a prefix for all VPA-related metrics namespaces
 	TopMetricsNamespace = "vpa_"
 
-	// The metrics will distinguish VPA sizes up to 2^MaxVpaSizeLog (~1M)
+	// MaxVpaSizeLog - The metrics will distinguish VPA sizes up to 2^MaxVpaSizeLog (~1M)
 	// Anything above that size will be reported in the top bucket.
 	MaxVpaSizeLog = 20
 )