Skip to content

Commit 2d8ba32

Browse files
authored
Merge pull request kubernetes#3367 from bskiba/new-webhook
Switch VPA admission controller to v1 admissionregistration API
2 parents 4882a2a + b7922d7 commit 2d8ba32

File tree

1 file changed

+14
-13
lines changed
  • vertical-pod-autoscaler/pkg/admission-controller

1 file changed

+14
-13
lines changed

vertical-pod-autoscaler/pkg/admission-controller/config.go

Lines changed: 14 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ import (
2121
"crypto/tls"
2222
"time"
2323

24-
"k8s.io/api/admissionregistration/v1beta1"
24+
admissionregistration "k8s.io/api/admissionregistration/v1"
2525
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
2626
"k8s.io/client-go/kubernetes"
2727
"k8s.io/client-go/rest"
@@ -59,43 +59,44 @@ func configTLS(clientset *kubernetes.Clientset, serverCert, serverKey []byte) *t
5959
// by creating MutatingWebhookConfiguration.
6060
func selfRegistration(clientset *kubernetes.Clientset, caCert []byte, namespace, serviceName, url string, registerByURL bool) {
6161
time.Sleep(10 * time.Second)
62-
client := clientset.AdmissionregistrationV1beta1().MutatingWebhookConfigurations()
62+
client := clientset.AdmissionregistrationV1().MutatingWebhookConfigurations()
6363
_, err := client.Get(context.TODO(), webhookConfigName, metav1.GetOptions{})
6464
if err == nil {
6565
if err2 := client.Delete(context.TODO(), webhookConfigName, metav1.DeleteOptions{}); err2 != nil {
6666
klog.Fatal(err2)
6767
}
6868
}
69-
RegisterClientConfig := v1beta1.WebhookClientConfig{}
69+
RegisterClientConfig := admissionregistration.WebhookClientConfig{}
7070
if !registerByURL {
71-
RegisterClientConfig.Service = &v1beta1.ServiceReference{
71+
RegisterClientConfig.Service = &admissionregistration.ServiceReference{
7272
Namespace: namespace,
7373
Name: serviceName,
7474
}
7575
} else {
7676
RegisterClientConfig.URL = &url
7777
}
78-
sideEffects := v1beta1.SideEffectClassNone
78+
sideEffects := admissionregistration.SideEffectClassNone
7979
RegisterClientConfig.CABundle = caCert
80-
webhookConfig := &v1beta1.MutatingWebhookConfiguration{
80+
webhookConfig := &admissionregistration.MutatingWebhookConfiguration{
8181
ObjectMeta: metav1.ObjectMeta{
8282
Name: webhookConfigName,
8383
},
84-
Webhooks: []v1beta1.MutatingWebhook{
84+
Webhooks: []admissionregistration.MutatingWebhook{
8585
{
86-
Name: "vpa.k8s.io",
87-
Rules: []v1beta1.RuleWithOperations{
86+
Name: "vpa.k8s.io",
87+
AdmissionReviewVersions: []string{"v1beta1"},
88+
Rules: []admissionregistration.RuleWithOperations{
8889
{
89-
Operations: []v1beta1.OperationType{v1beta1.Create},
90-
Rule: v1beta1.Rule{
90+
Operations: []admissionregistration.OperationType{admissionregistration.Create},
91+
Rule: admissionregistration.Rule{
9192
APIGroups: []string{""},
9293
APIVersions: []string{"v1"},
9394
Resources: []string{"pods"},
9495
},
9596
},
9697
{
97-
Operations: []v1beta1.OperationType{v1beta1.Create, v1beta1.Update},
98-
Rule: v1beta1.Rule{
98+
Operations: []admissionregistration.OperationType{admissionregistration.Create, admissionregistration.Update},
99+
Rule: admissionregistration.Rule{
99100
APIGroups: []string{"autoscaling.k8s.io"},
100101
APIVersions: []string{"*"},
101102
Resources: []string{"verticalpodautoscalers"},

0 commit comments

Comments
 (0)