Skip to content

Commit 383a506

Browse files
authored
Merge pull request kubernetes#3679 from gjtempleton/CA-Chart-Rename
Return cluster-autoscaler-chart Chart name to cluster-autoscaler
2 parents 8102e79 + e6c42be commit 383a506

20 files changed

+46
-20
lines changed

.github/workflows/release.yaml

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,16 +4,24 @@ jobs:
44
steps:
55
- name: Checkout
66
uses: actions/checkout@v2
7-
- name: Fetch history
8-
run: git fetch --prune --unshallow
7+
with:
8+
fetch-depth: 0
9+
910
- name: Configure Git
1011
run: |
1112
git config user.name "${GITHUB_ACTOR}"
1213
git config user.email "${GITHUB_ACTOR}@users.noreply.github.com"
14+
15+
- name: Install Helm
16+
uses: azure/setup-helm@v1
17+
with:
18+
version: v3.4.0
19+
1320
- env:
1421
CR_TOKEN: ${{ secrets.GITHUB_TOKEN }}
22+
CR_RELEASE_NAME_TEMPLATE: "cluster-autoscaler-chart-{{ .Version }}"
1523
name: Run chart-releaser
16-
uses: helm/chart-releaser-action@v1.0.0-rc.2
24+
uses: helm/chart-releaser-action@v1.1.0
1725
name: Release Charts
1826
on:
1927
push:
File renamed without changes.

charts/cluster-autoscaler-chart/Chart.yaml renamed to charts/cluster-autoscaler/Chart.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,8 @@ maintainers:
1313
name: gjtempleton
1414
1515
name: sc250024
16-
name: cluster-autoscaler-chart
16+
name: cluster-autoscaler
1717
sources:
1818
- https://github.com/kubernetes/autoscaler/tree/master/cluster-autoscaler
1919
type: application
20-
version: 1.1.1
20+
version: 9.0.0

charts/cluster-autoscaler-chart/README.md renamed to charts/cluster-autoscaler/README.md

Lines changed: 17 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# cluster-autoscaler-chart
1+
# cluster-autoscaler
22

33
Scales Kubernetes worker nodes within autoscaling groups.
44

@@ -8,11 +8,11 @@ Scales Kubernetes worker nodes within autoscaling groups.
88
$ helm repo add autoscaler https://kubernetes.github.io/autoscaler
99

1010
# Method 1 - Using Autodiscovery
11-
$ helm install my-release autoscaler/cluster-autoscaler-chart \
11+
$ helm install my-release autoscaler/cluster-autoscaler \
1212
--set 'autoDiscovery.clusterName'=<CLUSTER NAME>
1313

1414
# Method 2 - Specifying groups manually
15-
$ helm install my-release autoscaler/cluster-autoscaler-chart \
15+
$ helm install my-release autoscaler/cluster-autoscaler \
1616
--set "autoscalingGroups[0].name=your-asg-name" \
1717
--set "autoscalingGroups[0].maxSize=10" \
1818
--set "autoscalingGroups[0].minSize=1"
@@ -35,7 +35,16 @@ This chart bootstraps a cluster-autoscaler deployment on a [Kubernetes](http://k
3535
The previous `cluster-autoscaler` Helm chart hosted at [helm/charts](https://github.com/helm/charts) has been moved to this repository in accordance with the [Deprecation timeline](https://github.com/helm/charts#deprecation-timeline). Note that a few things have changed between this version and the old version:
3636

3737
- This repository **only** supports Helm chart installations using Helm 3+ since the `apiVersion` on the charts has been marked as `v2`.
38-
- Previous versions of the Helm chart have not been migrated, and the version was reset to `1.0.0` at the onset. If you are looking for old versions of the chart, it's best to run `helm pull stable/cluster-autoscaler --version <your-version>` until you are ready to move to this repository's version.
38+
- Previous versions of the Helm chart have not been migrated, and the version was reset to `1.0.0` initially. If you are looking for old versions of the chart, it's best to run `helm pull stable/cluster-autoscaler --version <your-version>` until you are ready to move to this repository's version.
39+
- The previous versioning scheme has been returned to as of version `9.0.0` for ease of migration from the previous chart location.
40+
41+
## Migration from 1.X to 9.X+ versions of this Chart
42+
43+
On initial adoption of this chart this chart was renamed from `cluster-autoscaler` to `cluster-autoscaler-chart` due to technical limitations. This affects all `1.X` releases of the chart.
44+
45+
Releases of the chart from `9.0.0` onwards return the naming of the chart to `cluster-autoscaler` and return to following the versioning established by the chart's previous location.
46+
47+
To migrate from a 1.X release of the chart to a `9.0.0` or later release, you should first uninstall your `1.X` install of the `cluster-autoscaler-chart` chart, before performing the installation of the new `cluster-autoscaler` chart.
3948

4049
## Installing the Chart
4150

@@ -66,7 +75,7 @@ Auto-discovery finds ASGs tags as below and automatically manages them based on
6675
- Set `awsAccessKeyID=<YOUR AWS KEY ID>` and `awsSecretAccessKey=<YOUR AWS SECRET KEY>` if you want to [use AWS credentials directly instead of an instance role](https://github.com/kubernetes/autoscaler/blob/master/cluster-autoscaler/cloudprovider/aws/README.md#using-aws-credentials)
6776

6877
```console
69-
$ helm install my-release autoscaler/cluster-autoscaler-chart --set autoDiscovery.clusterName=<CLUSTER NAME>
78+
$ helm install my-release autoscaler/cluster-autoscaler --set autoDiscovery.clusterName=<CLUSTER NAME>
7079
```
7180

7281
#### Specifying groups manually
@@ -77,7 +86,7 @@ Without autodiscovery, specify an array of elements each containing ASG name, mi
7786
- Either provide a yaml file setting `autoscalingGroups` (see values.yaml) or use `--set` e.g.:
7887

7988
```console
80-
$ helm install my-release autoscaler/cluster-autoscaler-chart \
89+
$ helm install my-release autoscaler/cluster-autoscaler \
8190
--set "autoscalingGroups[0].name=your-asg-name" \
8291
--set "autoscalingGroups[0].maxSize=10" \
8392
--set "autoscalingGroups[0].minSize=1"
@@ -138,7 +147,7 @@ The following parameters are required:
138147
To use Managed Instance Group (MIG) auto-discovery, provide a YAML file setting `autoscalingGroupsnamePrefix` (see values.yaml) or use `--set` when installing the Chart - e.g.
139148

140149
```console
141-
$ helm install my-release autoscaler/cluster-autoscaler-chart \
150+
$ helm install my-release autoscaler/cluster-autoscaler \
142151
--set "autoscalingGroupsnamePrefix[0].name=your-ig-prefix,autoscalingGroupsnamePrefix[0].maxSize=10,autoscalingGroupsnamePrefi[0].minSize=1" \
143152
--set autoDiscovery.clusterName=<CLUSTER NAME> \
144153
--set cloudProvider=gce
@@ -183,7 +192,7 @@ Example values files can be found [here](../../cluster-autoscaler/cloudprovider/
183192
Install the chart with
184193
185194
```
186-
$ helm install my-release autoscaler/cluster-autoscaler-chart -f myvalues.yaml
195+
$ helm install my-release autoscaler/cluster-autoscaler -f myvalues.yaml
187196
```
188197
189198
## Uninstalling the Chart

charts/cluster-autoscaler-chart/README.md.gotmpl renamed to charts/cluster-autoscaler/README.md.gotmpl

Lines changed: 16 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,11 @@
88
$ helm repo add autoscaler https://kubernetes.github.io/autoscaler
99

1010
# Method 1 - Using Autodiscovery
11-
$ helm install my-release autoscaler/cluster-autoscaler-chart \
11+
$ helm install my-release autoscaler/cluster-autoscaler \
1212
--set 'autoDiscovery.clusterName'=<CLUSTER NAME>
1313

1414
# Method 2 - Specifying groups manually
15-
$ helm install my-release autoscaler/cluster-autoscaler-chart \
15+
$ helm install my-release autoscaler/cluster-autoscaler \
1616
--set "autoscalingGroups[0].name=your-asg-name" \
1717
--set "autoscalingGroups[0].maxSize=10" \
1818
--set "autoscalingGroups[0].minSize=1"
@@ -35,7 +35,16 @@ This chart bootstraps a cluster-autoscaler deployment on a [Kubernetes](http://k
3535
The previous `cluster-autoscaler` Helm chart hosted at [helm/charts](https://github.com/helm/charts) has been moved to this repository in accordance with the [Deprecation timeline](https://github.com/helm/charts#deprecation-timeline). Note that a few things have changed between this version and the old version:
3636

3737
- This repository **only** supports Helm chart installations using Helm 3+ since the `apiVersion` on the charts has been marked as `v2`.
38-
- Previous versions of the Helm chart have not been migrated, and the version was reset to `1.0.0` at the onset. If you are looking for old versions of the chart, it's best to run `helm pull stable/cluster-autoscaler --version <your-version>` until you are ready to move to this repository's version.
38+
- Previous versions of the Helm chart have not been migrated, and the version was reset to `1.0.0` initially. If you are looking for old versions of the chart, it's best to run `helm pull stable/cluster-autoscaler --version <your-version>` until you are ready to move to this repository's version.
39+
- The previous versioning scheme has been returned to as of version `9.0.0` for ease of migration from the previous chart location.
40+
41+
## Migration from 1.X to 9.X+ versions of this Chart
42+
43+
On initial adoption of this chart this chart was renamed from `cluster-autoscaler` to `cluster-autoscaler-chart` due to technical limitations. This affects all `1.X` releases of the chart.
44+
45+
Releases of the chart from `9.0.0` onwards return the naming of the chart to `cluster-autoscaler` and return to following the versioning established by the chart's previous location.
46+
47+
To migrate from a 1.X release of the chart to a `9.0.0` or later release, you should first uninstall your `1.X` install of the `cluster-autoscaler-chart` chart, before performing the installation of the new `cluster-autoscaler` chart.
3948

4049
## Installing the Chart
4150

@@ -66,7 +75,7 @@ Auto-discovery finds ASGs tags as below and automatically manages them based on
6675
- Set `awsAccessKeyID=<YOUR AWS KEY ID>` and `awsSecretAccessKey=<YOUR AWS SECRET KEY>` if you want to [use AWS credentials directly instead of an instance role](https://github.com/kubernetes/autoscaler/blob/master/cluster-autoscaler/cloudprovider/aws/README.md#using-aws-credentials)
6776

6877
```console
69-
$ helm install my-release autoscaler/cluster-autoscaler-chart --set autoDiscovery.clusterName=<CLUSTER NAME>
78+
$ helm install my-release autoscaler/cluster-autoscaler --set autoDiscovery.clusterName=<CLUSTER NAME>
7079
```
7180

7281
#### Specifying groups manually
@@ -77,7 +86,7 @@ Without autodiscovery, specify an array of elements each containing ASG name, mi
7786
- Either provide a yaml file setting `autoscalingGroups` (see values.yaml) or use `--set` e.g.:
7887

7988
```console
80-
$ helm install my-release autoscaler/cluster-autoscaler-chart \
89+
$ helm install my-release autoscaler/cluster-autoscaler \
8190
--set "autoscalingGroups[0].name=your-asg-name" \
8291
--set "autoscalingGroups[0].maxSize=10" \
8392
--set "autoscalingGroups[0].minSize=1"
@@ -138,7 +147,7 @@ The following parameters are required:
138147
To use Managed Instance Group (MIG) auto-discovery, provide a YAML file setting `autoscalingGroupsnamePrefix` (see values.yaml) or use `--set` when installing the Chart - e.g.
139148

140149
```console
141-
$ helm install my-release autoscaler/cluster-autoscaler-chart \
150+
$ helm install my-release autoscaler/cluster-autoscaler \
142151
--set "autoscalingGroupsnamePrefix[0].name=your-ig-prefix,autoscalingGroupsnamePrefix[0].maxSize=10,autoscalingGroupsnamePrefi[0].minSize=1" \
143152
--set autoDiscovery.clusterName=<CLUSTER NAME> \
144153
--set cloudProvider=gce
@@ -183,7 +192,7 @@ Example values files can be found [here](../../cluster-autoscaler/cloudprovider/
183192
Install the chart with
184193

185194
```
186-
$ helm install my-release autoscaler/cluster-autoscaler-chart -f myvalues.yaml
195+
$ helm install my-release autoscaler/cluster-autoscaler -f myvalues.yaml
187196
```
188197

189198
## Uninstalling the Chart
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.

0 commit comments

Comments
 (0)