Skip to content

Commit 851d677

Browse files
authored
Merge pull request kubernetes#3390 from bskiba/master
Descriptive error on failed cert generation
2 parents a1c06d5 + 2d4ad5d commit 851d677

File tree

1 file changed

+9
-1
lines changed
  • vertical-pod-autoscaler/pkg/admission-controller

1 file changed

+9
-1
lines changed

vertical-pod-autoscaler/pkg/admission-controller/gencerts.sh

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,9 @@
1717
# Generates the a CA cert, a server key, and a server cert signed by the CA.
1818
# reference:
1919
# https://github.com/kubernetes/kubernetes/blob/master/plugin/pkg/admission/webhook/gencerts.sh
20-
set -e
20+
set -o errexit
21+
set -o nounset
22+
set -o pipefail
2123

2224
CN_BASE="vpa_webhook"
2325
TMP_DIR="/tmp/vpa-certs"
@@ -38,7 +40,13 @@ EOF
3840

3941
# Create a certificate authority
4042
openssl genrsa -out ${TMP_DIR}/caKey.pem 2048
43+
set +o errexit
4144
openssl req -x509 -new -nodes -key ${TMP_DIR}/caKey.pem -days 100000 -out ${TMP_DIR}/caCert.pem -subj "/CN=${CN_BASE}_ca" -addext "subjectAltName = DNS:${CN_BASE}_ca"
45+
if [[ $? -ne 0 ]]; then
46+
echo "ERROR: Failed to create CA certificate for self-signing. If the error is \"unknown option -addext\", update your openssl version or deploy VPA from the vpa-release-0.8 branch."
47+
exit 1
48+
fi
49+
set -o errexit
4250

4351
# Create a server certiticate
4452
openssl genrsa -out ${TMP_DIR}/serverKey.pem 2048

0 commit comments

Comments
 (0)