Skip to content

Commit d987394

Browse files
committed
review fixes.
added explicit ignoring for write func
1 parent 7fa7a14 commit d987394

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

cluster-autoscaler/cloudprovider/gce/mig_target_sizes_provider.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,9 +56,9 @@ func (c *cachingMigTargetSizesProvider) GetMigTargetSize(migRef GceRef) (int64,
5656

5757
newTargetSizes, err := c.fillInMigTargetSizeCache()
5858

59-
// if we still do not have value here return an error
6059
size, found := newTargetSizes[migRef]
6160
if err != nil || !found {
61+
// fallback to querying for single mig
6262
targetSize, err = c.gceClient.FetchMigTargetSize(migRef)
6363
if err != nil {
6464
return 0, err

cluster-autoscaler/utils/test/test_utils.go

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -225,7 +225,7 @@ func NewHttpServerMock() *HttpServerMock {
225225
mux.HandleFunc("/",
226226
func(w http.ResponseWriter, req *http.Request) {
227227
result := httpServerMock.handle(req.URL.Path)
228-
w.Write([]byte(result))
228+
_, _ = w.Write([]byte(result))
229229
})
230230

231231
server := httptest.NewServer(mux)
@@ -246,8 +246,7 @@ func NewHttpServerMockWithStatusCode() *HttpServerMock {
246246
func(w http.ResponseWriter, req *http.Request) {
247247
code, result := httpServerMock.handleWithStatusCode(req.URL.Path)
248248
w.WriteHeader(code)
249-
w.Write([]byte(result))
250-
//w.Write([]byte("status: " + string(code) + "\n" + result))
249+
_, _ = w.Write([]byte(result))
251250
})
252251

253252
server := httptest.NewServer(mux)

0 commit comments

Comments
 (0)