Merge pull request kubernetes#3211 from kgolab/vpa-metrics-fix-log2

k8s-ci-robot · web-flow · commit e0f63c1caeec · 2020-06-08T08:49:48.000-07:00
Fix use of log2 label value
diff --git a/vertical-pod-autoscaler/pkg/utils/metrics/quality/quality.go b/vertical-pod-autoscaler/pkg/utils/metrics/quality/quality.go
@@ -214,7 +214,8 @@ func ObserveRecommendationChange(previous, current corev1.ResourceList, updateMo
 
 		if oldValue > 0.0 {
 			diff := newValue/oldValue - 1.0 // -1.0 to report decreases as negative values and keep 0.0 neutral
-			relativeRecommendationChange.WithLabelValues(updateModeToString(updateMode), string(resource), string(vpaSize)).Observe(diff)
+			log2 := metrics.GetVpaSizeLog2(vpaSize)
+			relativeRecommendationChange.WithLabelValues(updateModeToString(updateMode), string(resource), strconv.Itoa(log2)).Observe(diff)
 		} else {
 			klog.Warningf("Cannot compare as old recommendation for %v is 0. VPA mode: %v, size: %v", resource, updateMode, vpaSize)
 		}

Original file line number	Diff line number	Diff line change
`@@ -214,7 +214,8 @@ func ObserveRecommendationChange(previous, current corev1.ResourceList, updateMo`
`214`	`214`
`215`	`215`	`if oldValue > 0.0 {`
`216`	`216`	`diff := newValue/oldValue - 1.0 // -1.0 to report decreases as negative values and keep 0.0 neutral`
`217`		`- relativeRecommendationChange.WithLabelValues(updateModeToString(updateMode), string(resource), string(vpaSize)).Observe(diff)`
	`217`	`+ log2 := metrics.GetVpaSizeLog2(vpaSize)`
	`218`	`+ relativeRecommendationChange.WithLabelValues(updateModeToString(updateMode), string(resource), strconv.Itoa(log2)).Observe(diff)`
`218`	`219`	`} else {`
`219`	`220`	`klog.Warningf("Cannot compare as old recommendation for %v is 0. VPA mode: %v, size: %v", resource, updateMode, vpaSize)`
`220`	`221`	`}`