Merge pull request kubernetes#3111 from fantayeneh/MINOR-Typo

k8s-ci-robot · web-flow · commit f11443819f46 · 2020-05-04T13:53:09.000-07:00
Typo - Assert using the right containers
diff --git a/vertical-pod-autoscaler/pkg/recommender/logic/recommender_test.go b/vertical-pod-autoscaler/pkg/recommender/logic/recommender_test.go
@@ -59,8 +59,8 @@ func TestMinResourcesSplitAcrossContainers(t *testing.T) {
 
 	recommendedResources := recommender.GetRecommendedPodResources(containerNameToAggregateStateMap)
 	assert.Equal(t, model.CPUAmountFromCores((*podMinCPUMillicores/1000)/2), recommendedResources["container-1"].Target[model.ResourceCPU])
-	assert.Equal(t, model.CPUAmountFromCores((*podMinCPUMillicores/1000)/2), recommendedResources["container-1"].Target[model.ResourceCPU])
-	assert.Equal(t, model.MemoryAmountFromBytes((*podMinMemoryMb*1024*1024)/2), recommendedResources["container-2"].Target[model.ResourceMemory])
+	assert.Equal(t, model.CPUAmountFromCores((*podMinCPUMillicores/1000)/2), recommendedResources["container-2"].Target[model.ResourceCPU])
+	assert.Equal(t, model.MemoryAmountFromBytes((*podMinMemoryMb*1024*1024)/2), recommendedResources["container-1"].Target[model.ResourceMemory])
 	assert.Equal(t, model.MemoryAmountFromBytes((*podMinMemoryMb*1024*1024)/2), recommendedResources["container-2"].Target[model.ResourceMemory])
 }
 

Original file line number	Diff line number	Diff line change
`@@ -59,8 +59,8 @@ func TestMinResourcesSplitAcrossContainers(t *testing.T) {`
`59`	`59`
`60`	`60`	`recommendedResources := recommender.GetRecommendedPodResources(containerNameToAggregateStateMap)`
`61`	`61`	`assert.Equal(t, model.CPUAmountFromCores((*podMinCPUMillicores/1000)/2), recommendedResources["container-1"].Target[model.ResourceCPU])`
`62`		`- assert.Equal(t, model.CPUAmountFromCores((*podMinCPUMillicores/1000)/2), recommendedResources["container-1"].Target[model.ResourceCPU])`
`63`		`- assert.Equal(t, model.MemoryAmountFromBytes((podMinMemoryMb1024*1024)/2), recommendedResources["container-2"].Target[model.ResourceMemory])`
	`62`	`+ assert.Equal(t, model.CPUAmountFromCores((*podMinCPUMillicores/1000)/2), recommendedResources["container-2"].Target[model.ResourceCPU])`
	`63`	`+ assert.Equal(t, model.MemoryAmountFromBytes((podMinMemoryMb1024*1024)/2), recommendedResources["container-1"].Target[model.ResourceMemory])`
`64`	`64`	`assert.Equal(t, model.MemoryAmountFromBytes((podMinMemoryMb1024*1024)/2), recommendedResources["container-2"].Target[model.ResourceMemory])`
`65`	`65`	`}`
`66`	`66`