Skip to content

Commit f1a84f4

Browse files
log error when removing node from unremovable map
1 parent 0215339 commit f1a84f4

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

cluster-autoscaler/core/scale_down.go

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -624,10 +624,13 @@ func (sd *ScaleDown) updateUnremovableNodes() {
624624
}
625625
newUnremovableNodes := make(map[string]time.Time, len(sd.unremovableNodes))
626626
for oldUnremovable, since := range sd.unremovableNodes {
627-
if _, err := sd.context.ClusterSnapshot.NodeInfos().Get(oldUnremovable); err == nil {
628-
// Nodes that are in the cluster should not be deleted.
629-
newUnremovableNodes[oldUnremovable] = since
627+
if _, err := sd.context.ClusterSnapshot.NodeInfos().Get(oldUnremovable); err != nil {
628+
// Not logging on error level as most likely cause is that node is no longer in the cluster.
629+
klog.Infof("Can't retrieve node %s from snapshot, removing from unremovable map, err: %v", oldUnremovable, err)
630+
continue
630631
}
632+
// Keep nodes that are still in the cluster.
633+
newUnremovableNodes[oldUnremovable] = since
631634
}
632635
sd.unremovableNodes = newUnremovableNodes
633636
}

0 commit comments

Comments
 (0)