fix serde dups

Author: elringus

src/cs/Bootsharp.Publish/Common/TypeConverter/TypeCrawler.cs

@@ -9,10 +9,11 @@ internal sealed class TypeCrawler
     public void Crawl (Type type)
     {
         if (!ShouldCrawl(type)) return;
-        type = GetUnderlyingType(type);
-        if (!crawled.Add(type)) return;
-        CrawlProperties(type);
-        CrawlBaseType(type);
+        var underlyingType = GetUnderlyingType(type);
+        if (!crawled.Add(underlyingType)) return;
+        CrawlProperties(underlyingType);
+        CrawlBaseType(underlyingType);
+        crawled.Add(type);
     }
 
     private bool ShouldCrawl (Type type)

src/cs/Bootsharp.Publish/Emit/SerializerGenerator.cs

@@ -11,8 +11,8 @@ internal sealed class SerializerGenerator
 
     public string Generate (SolutionInspection inspection)
     {
-        CollectAttributes(inspection);
-        CollectDuplicates(inspection);
+        CollectTopLevel(inspection);
+        CollectCrawled(inspection);
         if (attributes.Count == 0) return "";
         return
             $"""
@@ -30,7 +30,7 @@ internal partial class SerializerContext : JsonSerializerContext;
              """;
     }
 
-    private void CollectAttributes (SolutionInspection inspection)
+    private void CollectTopLevel (SolutionInspection inspection)
     {
         var metas = inspection.StaticMethods
             .Concat(inspection.StaticInterfaces.SelectMany(i => i.Methods))
@@ -53,11 +53,10 @@ private void CollectFromValue (ValueMeta meta)
         attributes.Add(BuildAttribute(meta.Type));
     }
 
-    private void CollectDuplicates (SolutionInspection inspection)
+    private void CollectCrawled (SolutionInspection inspection)
     {
-        var names = new HashSet<string>();
-        foreach (var type in inspection.Crawled.DistinctBy(t => t.FullName))
-            if (ShouldSerialize(type) && !names.Add(type.Name))
+        foreach (var type in inspection.Crawled)
+            if (ShouldSerialize(type))
                 attributes.Add(BuildAttribute(type));
     }
 

src/cs/Bootsharp.Publish/Pack/DeclarationGenerator/TypeDeclarationGenerator.cs

@@ -20,7 +20,7 @@ internal sealed class TypeDeclarationGenerator (Preferences prefs)
     public string Generate (SolutionInspection inspection)
     {
         instanced = [..inspection.InstancedInterfaces];
-        types = inspection.Crawled.OrderBy(GetNamespace).ToArray();
+        types = inspection.Crawled.Where(FilterCrawled).OrderBy(GetNamespace).ToArray();
         for (index = 0; index < types.Length; index++)
             DeclareType();
         return builder.ToString();
@@ -32,6 +32,11 @@ private Type GetTypeAt (int index)
         return type.IsGenericType ? type.GetGenericTypeDefinition() : type;
     }
 
+    private bool FilterCrawled (Type type)
+    {
+        return !IsList(type) && !IsCollection(type) && !IsNullable(type);
+    }
+
     private void DeclareType ()
     {
         if (ShouldOpenNamespace()) OpenNamespace();