Skip to content

Commit 5d1b0f8

Browse files
committed
Update project files and dependencies to resolve Build issues.
- Removed `ElsaStudioVersion` from `Directory.Build.props`. - Added `PackageVersions` group in `Directory.Packages.props` with `ElsaStudioVersion` and new `Moq` package version. - Updated input retrieval method in `ConfigureLiquidEngine.cs` to use `ActivityInput`. - Clarified import for `InvokingActivityCallback` in `ScheduledChildCallbackBehavior.cs`. - Changed target framework to `net9.0` in `Elsa.Http.UnitTests.csproj` and updated package references for flexibility.
1 parent dff2576 commit 5d1b0f8

File tree

5 files changed

+14
-13
lines changed

5 files changed

+14
-13
lines changed

Directory.Build.props

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,4 @@
3636
<!-- IL trimming warnings -->
3737
<NoWarn>$(NoWarn);IL2026;IL2046;IL2057;IL2067;IL2070;IL2072;IL2075;IL2087;IL2091</NoWarn>
3838
</PropertyGroup>
39-
<PropertyGroup>
40-
<ElsaStudioVersion>3.6.0-preview.1029</ElsaStudioVersion>
41-
</PropertyGroup>
4239
</Project>

Directory.Packages.props

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,10 @@
44
<CentralPackageTransitivePinningEnabled>false</CentralPackageTransitivePinningEnabled>
55
</PropertyGroup>
66

7+
<PropertyGroup Label="PackageVersions">
8+
<ElsaStudioVersion>3.6.0-preview.1029</ElsaStudioVersion>
9+
</PropertyGroup>
10+
711
<ItemGroup Label="Elsa">
812
<PackageVersion Include="Elsa.Actors.ProtoActor" Version="3.6.0-preview.29" />
913
<PackageVersion Include="Elsa.Alterations" Version="3.6.0-preview.29" />
@@ -156,6 +160,7 @@
156160
<PackageVersion Include="Microsoft.Identity.Client" Version="4.71.1" />
157161
<PackageVersion Include="Microsoft.NET.Test.Sdk" Version="17.14.0" />
158162
<PackageVersion Include="Microsoft.SourceLink.GitHub" Version="8.0.0" />
163+
<PackageVersion Include="Moq" Version="4.20.72" />
159164
<PackageVersion Include="MySql.Data" Version="9.3.0" />
160165
<PackageVersion Include="MongoDB.Driver" Version="3.4.0" />
161166
<PackageVersion Include="MongoDB.Driver.Core.Extensions.DiagnosticSources" Version="2.0.0" />

src/modules/Elsa.Expressions.Liquid/Handlers/ConfigureLiquidEngine.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ private Task<FluidValue> GetInput(ExpressionExecutionContext context, string key
7777
{
7878
// First, check if the current activity has inputs
7979
if (context.TryGetActivityExecutionContext(out var activityExecutionContext) &&
80-
activityExecutionContext.Input.TryGetValue(key, out var activityValue))
80+
activityExecutionContext.ActivityInput.TryGetValue(key, out var activityValue))
8181
{
8282
return Task.FromResult(activityValue == null ? NilValue.Instance : FluidValue.Create(activityValue, options));
8383
}

src/modules/Elsa.Workflows.Core/Behaviors/ScheduledChildCallbackBehavior.cs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
using Elsa.Mediator.Contracts;
2-
using Elsa.Workflows.Notifications;
32
using Elsa.Workflows.Signals;
43
using JetBrains.Annotations;
54

@@ -31,7 +30,7 @@ private async ValueTask OnActivityCompletedAsync(ActivityCompleted signal, Signa
3130
completedContext.TargetContext.Tag = tag;
3231

3332
var mediator = activityExecutionContext.GetRequiredService<IMediator>();
34-
var invokingActivityCallbackNotification = new InvokingActivityCallback(activityExecutionContext, childActivityExecutionContext);
33+
var invokingActivityCallbackNotification = new Notifications.InvokingActivityCallback(activityExecutionContext, childActivityExecutionContext);
3534
await mediator.SendAsync(invokingActivityCallbackNotification, context.CancellationToken);
3635

3736
await callbackEntry.CompletionCallback(completedContext);

test/unit/Elsa.Http.UnitTests/Elsa.Http.UnitTests.csproj

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
1-
<Project Sdk="Microsoft.NET.Sdk">
1+
<Project Sdk="Microsoft.NET.Sdk">
22

33
<PropertyGroup>
4-
<TargetFramework>net8.0</TargetFramework>
4+
<TargetFramework>net9.0</TargetFramework>
55
<ImplicitUsings>enable</ImplicitUsings>
66
<Nullable>enable</Nullable>
77
<LangVersion>latest</LangVersion>
@@ -10,14 +10,14 @@
1010
</PropertyGroup>
1111

1212
<ItemGroup>
13-
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.9.0" />
14-
<PackageReference Include="Moq" Version="4.20.70" />
15-
<PackageReference Include="xunit" Version="2.7.0" />
16-
<PackageReference Include="xunit.runner.visualstudio" Version="2.5.7">
13+
<PackageReference Include="Microsoft.NET.Test.Sdk" />
14+
<PackageReference Include="Moq" />
15+
<PackageReference Include="xunit" />
16+
<PackageReference Include="xunit.runner.visualstudio" >
1717
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
1818
<PrivateAssets>all</PrivateAssets>
1919
</PackageReference>
20-
<PackageReference Include="coverlet.collector" Version="6.0.0">
20+
<PackageReference Include="coverlet.collector" >
2121
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
2222
<PrivateAssets>all</PrivateAssets>
2323
</PackageReference>

0 commit comments

Comments
 (0)