Skip to content

Commit 9185d1f

Browse files
Copilotsfmskywalker
andcommitted
Address PR feedback: fix async patterns, add concrete example, improve security guidance, clarify Studio hosting
Co-authored-by: sfmskywalker <938393+sfmskywalker@users.noreply.github.com>
1 parent 2105443 commit 9185d1f

1 file changed

Lines changed: 5 additions & 4 deletions

File tree

getting-started/architecture-overview.md

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ builder.Services.AddElsa(elsa =>
9090

9191
### 2. Elsa Studio
9292

93-
**Elsa Studio** is a Blazor WebAssembly application that provides a visual designer for creating and managing workflows through a browser-based interface.
93+
**Elsa Studio** is a Blazor application built as a Razor Class Library (RCL) that provides a visual designer for creating and managing workflows through a browser-based interface. It can be hosted using any Blazor hosting model, including Blazor WebAssembly, Blazor Server, or embedded in other Blazor applications.
9494

9595
**Key Features:**
9696
- **Visual Workflow Designer**: Drag-and-drop interface for building workflows
@@ -350,12 +350,13 @@ These three concepts work together to enable event-driven, long-running workflow
350350
```csharp
351351
public class WaitForApprovalActivity : Activity
352352
{
353-
protected override void Execute(ActivityExecutionContext context)
353+
protected override async ValueTask ExecuteAsync(ActivityExecutionContext context)
354354
{
355355
// Create a bookmark with a payload
356356
context.CreateBookmark(
357357
new Bookmark("approval-required",
358358
payload: new { ApprovalId = "12345" }));
359+
await Task.CompletedTask;
359360
}
360361
}
361362
```
@@ -662,7 +663,7 @@ public class MyCustomActivity : CodeActivity
662663
ActivityExecutionContext context)
663664
{
664665
var input = context.Get(InputValue);
665-
var result = await ProcessAsync(input);
666+
var result = await Task.FromResult(input.ToUpper());
666667
context.Set(OutputValue, result);
667668
}
668669
}
@@ -1057,7 +1058,7 @@ public class CustomTenantResolver : ITenantResolver
10571058
elsa.UseIdentity(identity =>
10581059
{
10591060
identity.TokenOptions = options =>
1060-
options.SigningKey = "your-signing-key";
1061+
options.SigningKey = builder.Configuration["Jwt:SigningKey"]; // Use secure key storage in production
10611062
identity.UseAdminUserProvider();
10621063
});
10631064

0 commit comments

Comments
 (0)