Return no results, rather than throwing an exception when ->in() is passed an empty array. (#35)

Author: rrigby

lib/PicoDb/Builder/BaseConditionBuilder.php

@@ -243,7 +243,7 @@ public function in($column, array $values)
             $this->addCondition($this->db->escapeIdentifier($column).' IN ('.implode(', ', array_fill(0, count($values), '?')).')');
             $this->values = array_merge($this->values, $values);
         } else {
-            throw new \InvalidArgumentException('$values must not be an empty array');
+            $this->addCondition('0 = 1');
         }
     }
 

tests/MysqlTableTest.php

@@ -137,9 +137,10 @@ public function testConditionIn()
         $this->assertEquals('SELECT * FROM `test`   WHERE `a` IN (?, ?)', $table->in('a', array('b', 'c'))->buildSelectQuery());
         $this->assertEquals(array('b', 'c'), $table->getConditionBuilder()->getValues());
 
-        $this->expectException(\InvalidArgumentException::class);
         $table = $this->db->table('test');
-        $table->in('a', array());
+
+        $this->assertEquals('SELECT * FROM `test`   WHERE 0 = 1', $table->in('a', array())->buildSelectQuery());
+        $this->assertEquals(array(), $table->getConditionBuilder()->getValues());
     }
 
     public function testConditionInSubquery()

tests/PostgresTableTest.php

@@ -135,9 +135,10 @@ public function testConditionIn()
         $this->assertEquals('SELECT * FROM "test"   WHERE "a" IN (?, ?)', $table->in('a', array('b', 'c'))->buildSelectQuery());
         $this->assertEquals(array('b', 'c'), $table->getConditionBuilder()->getValues());
 
-        $this->expectException(\InvalidArgumentException::class);
         $table = $this->db->table('test');
-        $table->in('a', array());
+
+        $this->assertEquals('SELECT * FROM "test"   WHERE 0 = 1', $table->in('a', array())->buildSelectQuery());
+        $this->assertEquals(array(), $table->getConditionBuilder()->getValues());
     }
 
     public function testConditionInSubquery()

tests/SqliteTableTest.php

@@ -129,10 +129,11 @@ public function testConditionIn()
 
         $this->assertEquals('SELECT * FROM "test"   WHERE "a" IN (?, ?)', $table->in('a', array('b', 'c'))->buildSelectQuery());
         $this->assertEquals(array('b', 'c'), $table->getConditionBuilder()->getValues());
-
-        $this->expectException(\InvalidArgumentException::class);
+        
         $table = $this->db->table('test');
-        $table->in('a', array());
+
+        $this->assertEquals('SELECT * FROM "test"   WHERE 0 = 1', $table->in('a', array())->buildSelectQuery());
+        $this->assertEquals(array(), $table->getConditionBuilder()->getValues());
     }
 
     public function testConditionInSubquery()