🔧 fix: undefined cookie on default headers

Author: SaltyAom

example/a.ts

@@ -1,10 +1,10 @@
 import { Elysia, t } from '../src'
+import { cors } from '../../cors/src'
 
-export const app = new Elysia()
-	.get('', () => 'Level 2')
-	.get(
-		'/:id',
-		({ params: { id } }) => `You are in the identified route! ${id}`
-	)
+const app = new Elysia({ precompile: true })
+	.post('/', ({ body, cookie: { session } }) => {
+		session!.value = 'hi'
 
-type Res = typeof app._routes
+		return body
+	})
+	.listen(3000)

package.json

@@ -1,7 +1,7 @@
 {
   "name": "elysia",
   "description": "Ergonomic Framework for Human",
-  "version": "1.0.0-rc.11",
+  "version": "1.0.0-rc.13",
   "author": {
     "name": "saltyAom",
     "url": "https://github.com/SaltyAom",

src/compose.ts

@@ -381,11 +381,11 @@ export const composeHandler = ({
 		hooks.type !== 'none' &&
 		(inference.body || !!validator.body)
 
-	// @ts-ignore private
-	const setHeaders = app.setHeaders
+	// @ts-expect-error private
+	const defaultHeaders = app.setHeaders
 
+	// ? defaultHeaders doesn't imply that user will use headers in handler
 	const hasHeaders = inference.headers || validator.headers
-
 	const hasCookie = inference.cookie || !!validator.cookie
 
 	// @ts-ignore private property
@@ -488,7 +488,7 @@ export const composeHandler = ({
 		}`
 			: 'undefined'
 
-		if (hasHeaders || (setHeaders && !!Object.keys(setHeaders).length))
+		if (hasHeaders)
 			fnLiteral += `\nc.cookie = await parseCookie(c.set, c.headers.cookie, ${options})\n`
 		else
 			fnLiteral += `\nc.cookie = await parseCookie(c.set, c.request.headers.get('cookie'), ${options})\n`
@@ -552,7 +552,7 @@ export const composeHandler = ({
 		inference.set ||
 		hasTraceSet ||
 		hasHeaders ||
-		(setHeaders && !!Object.keys(setHeaders).length)
+		(defaultHeaders && !!Object.keys(defaultHeaders).length)
 
 	if (hasTrace) fnLiteral += '\nconst id = c.$$requestId\n'
 
@@ -1354,6 +1354,9 @@ export const composeGeneralHandler = (
 	let decoratorsLiteral = ''
 	let fnLiteral = ''
 
+	// @ts-expect-error private
+	const defaultHeaders = app.setHeaders
+
 	// @ts-ignore
 	for (const key of Object.keys(app.singleton.decorator))
 		decoratorsLiteral += `,${key}: app.singleton.decorator.${key}`
@@ -1365,7 +1368,7 @@ export const composeGeneralHandler = (
 	const route = router.find(request.method, path) ${
 		router.http.root.ALL ? '?? router.find("ALL", path)' : ''
 	}
-	
+
 	if (route === null)
 		return ${
 			app.event.error.length
@@ -1378,8 +1381,7 @@ export const composeGeneralHandler = (
 				: `error404.clone()`
 		}
 
-	ctx.params = route.params
-	`
+	ctx.params = route.params\n`
 
 	const shouldPrecompile =
 		app.config.precompile === true ||
@@ -1457,8 +1459,7 @@ export const composeGeneralHandler = (
 				store,
 				set: {
 					headers: ${
-						// @ts-ignore
-						Object.keys(app.setHeaders ?? {}).length
+						Object.keys(defaultHeaders ?? {}).length
 							? 'Object.assign({}, app.setHeaders)'
 							: '{}'
 					},
@@ -1529,8 +1530,7 @@ export const composeGeneralHandler = (
 			path,
 			set: {
 				headers: ${
-					// @ts-ignore
-					Object.keys(app.setHeaders ?? {}).length
+					Object.keys(defaultHeaders ?? {}).length
 						? 'Object.assign({}, app.setHeaders)'
 						: '{}'
 				},

src/context.ts

@@ -1,13 +1,13 @@
 import type { StatusMap, InvertedStatusMap } from './utils'
 import type { Cookie, ElysiaCookie } from './cookies'
 
+import { error, type ELYSIA_RESPONSE } from './error'
 import type {
 	RouteSchema,
 	Prettify,
 	GetPathParameter,
 	SingletonBase
 } from './types'
-import { error, type ELYSIA_RESPONSE, inlineError } from './error'
 
 type InvertedStatusMapKey = keyof InvertedStatusMap
 
@@ -95,7 +95,7 @@ export type Context<
 				}
 		  }
 		: {
-				error: typeof inlineError
+				error: typeof error
 		  }) &
 		Singleton['decorator'] &
 		Singleton['derive'] &

src/error.ts

@@ -25,19 +25,6 @@ export type ElysiaErrors =
 	| ValidationError
 	| InvalidCookieSignature
 
-/**
- * @deprecated
- * Use inline error instead
- *
- * Inline error can provide auto-completion
- * and type checking based on route schema
- *
- * @example
- * ```typescript
- * new Elysia()
- * 		.get('/', ({ error }) => error('418', ''))
- * ```
- */
 export const error = <
 	const Code extends number | keyof StatusMap,
 	const T = Code extends keyof InvertedStatusMap
@@ -68,37 +55,6 @@ export const error = <
 		_type: undefined as any
 	} as const)
 
-export const inlineError = <
-	const Code extends number | keyof StatusMap,
-	const T = Code extends keyof InvertedStatusMap
-		? InvertedStatusMap[Code]
-		: Code,
-	Status extends number = Code extends keyof StatusMap
-		? StatusMap[Code]
-		: Code
->(
-	code: Code,
-	response?: T
-): {
-	[ELYSIA_RESPONSE]: Status
-	response: T
-	_type: {
-		[ERROR_CODE in Status]: T
-	}
-	// eslint-disable-next-line sonarjs/no-identical-functions
-} =>
-	({
-		// @ts-expect-error
-		[ELYSIA_RESPONSE]: StatusMap[code] ?? code,
-		response:
-			response ??
-			(code in StatusMap
-				? // @ts-ignore
-				  StatusMap[code]
-				: code),
-		_type: undefined as any
-	} as const)
-
 export class InternalServerError extends Error {
 	code = 'INTERNAL_SERVER_ERROR'
 	status = 500