Missing root span

[d2verb]

What version of Elysia is running?

1.4.4

What platform is your computer?

Linux 6.6.87.2-microsoft-standard-WSL2 x86_64 x86_64

What steps can reproduce the bug?

1. bun create elysia elysia-otel -> bun add @elysiajs/opentelemetry.
2. Edit src/index.ts like below.

import { Elysia } from "elysia";
import { opentelemetry } from "@elysiajs/opentelemetry";
import { BatchSpanProcessor } from "@opentelemetry/sdk-trace-node";
import { OTLPTraceExporter } from "@opentelemetry/exporter-trace-otlp-proto";

const app = new Elysia()
  .use(opentelemetry({
    serviceName: "api",
    spanProcessors: [
      new BatchSpanProcessor(new OTLPTraceExporter({
        url: "https://api.honeycomb.io/v1/traces",
        headers: {
          "x-honeycomb-team": Bun.env.HONEYCOMB_TOKEN!,
        },
      })),
    ],
  }))
  .get("/health", () => ({ status: "ok" }))
  .listen(3000);

console.log(
  `🦊 Elysia is running at ${app.server?.hostname}:${app.server?.port}`
);

3. bun run dev
4. Access http://localhost:3000/health from browser (I used Chrome).
5. Go to dashboard of honeycomb to see sent traces.
6. Click any random trace to see the details, and you will notice that no trace has a root span as shown below.

What is the expected behavior?

All trace should have a root span.

What do you see instead?

No trace has a root span.

Additional information

I don't know if it's a bug or just me using it wrong, but I'll open an issue as a bug anyway. I'd be glad if someone could help me. 😢

Have you try removing the node_modules and bun.lockb and try again yet?

No response

[d2verb]

I'm using @elysiajs/opentelemetry v1.4.0

[jon-zuka]

I m having the same issue

[jon-zuka]

It is good practice to fix package versions, because there might be breaking changes not caught by the test suite. Downgrading to the following works:

"@elysiajs/opentelemetry": "1.3.1",
"elysia": "1.3.5",

EDIT had to go even lower with the Elysia version.

[jon-zuka]

You might find this useful for logging. I don't use traditional logging. I don't know why, I find all the information in the traces. Similar to when there is an error you will see a log in your span. You can add for different levels. I did not use pino. Instead I set an event.

export const tracing = {
  info: (message: string, fields = {}) => {
    getCurrentSpan()?.addEvent('info', { message, ...fields })
  },

  warn: (message: string, fields = {}) => {
    getCurrentSpan()?.addEvent('info', { message, ...fields })
  },

  error: (message: string, fields = {}) => {
    getCurrentSpan()?.addEvent('info', { message, ...fields })
    getCurrentSpan()?.setStatus({ code: SpanStatusCode.ERROR, message })
  },

  debug: (message: string, fields = {}) => {
    getCurrentSpan()?.addEvent('info', { message, ...fields })
  },
}

tracing.info("User not found", { ip: "123.123.123.123" })

[carlosmfreitas2409]

I have the same problem here.
And apparently when we throw some error, which will fall into onError, it is not finishing the root span and it is not renaming it.

[DaxServer]

I tested with the latest version 1.4.6 and the root span works

[jon-zuka]

Problem now is that throwing an error will not set the span status to error or the span is not red colored.

[mwstr]

Problem now is that throwing an error will not set the span status to error or the span is not red colored.

True. Neither root nor exact span where error happened.

I think the part of the problem is here. Span is ended and immediately checked whether it's ended. After patching this package to move span.end() after if condition I can now see where error happened and error is captured as an event:

But root span still has non-error status. I think it's overridden somewhere later