Skip to content

Conversation

@joshbax189
Copy link
Contributor

This fixes a few bugs in install-file. Some of them are:

  • can install from pacakge.tar and package.tar.gz
  • ignore package.el metadata errors when installing (i.e. treat package-install-file like package-install)
  • package name given to eask-package-install-file matches what package.el reports, so
    • packages in folders with different names install correctly, e.g. foo-0.0.1/foo-pkg.el

See extra tests cases in test/jest/install.test.js

@jcs090218
Copy link
Member

Very nice! My first implementation was a bit lazy due to my busy schedule. 🥲 I appreciate you for taking care of this! 🚀🥳

@joshbax189
Copy link
Contributor Author

No worries 👍

@jcs090218 jcs090218 merged commit 275dab4 into emacs-eask:master Apr 4, 2025
176 checks passed
@jcs090218
Copy link
Member

Merged! Thank you!! 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants