Obsolete inferior-ess-start-args (#889)

And use language-specific variables instead

Author: lionel-

lisp/ess-custom.el

@@ -1781,6 +1781,9 @@ for editing and then to be returned to the process.")
 The other variables ...-program should be changed, for the
 corresponding program.")
 
+(make-obsolete-variable 'inferior-ess-start-args
+                        "Use the language specific variables like `inferior-R-args'"
+                        "ESS 19.04")
 (defvar inferior-ess-start-args ""
   "String of arguments passed to the ESS process.
 If you wish to pass arguments to a process, see e.g. `inferior-R-args'.")

lisp/ess-gretl.el

@@ -486,7 +486,6 @@ end keywords as associated values.")
     (ess-smart-operators		. ess-r-smart-operators)
     (inferior-ess-exit-command		. "exit\n")
     ;;harmful for shell-mode's C-a: -- but "necessary" for ESS-help?
-    (inferior-ess-start-args		. "")
     (inferior-ess-language-start	. nil)
     (ess-STERM		. "iESS")
     )

lisp/ess-inf.el

@@ -125,23 +125,20 @@ If `ess-plain-first-buffername', then initial process is number-free."
                         (= n 1))) ; if not both first and plain-first add number
               (concat ":" (number-to-string n)))))
 
-(defun inferior-ess (&optional ess-start-args customize-alist no-wait)
+(defun inferior-ess (&optional start-args customize-alist no-wait)
   "Start inferior ESS process.
-
 Without a prefix argument, starts a new ESS process, or switches
-to the ESS process associated with the current buffer.  With
-ESS-START-ARGS (perhaps specified via \\[universal-argument]),
-starts the process with those args.  The current buffer is used
-if it is an `inferior-ess-mode' or `ess-transcript-mode' buffer.
+to the ESS process associated with the current buffer. With
+START-ARGS (perhaps specified via \\[universal-argument]), starts
+the process with those args. The current buffer is used if it is
+an `inferior-ess-mode' or `ess-transcript-mode' buffer.
 
 If `ess-ask-about-transfile' is non-nil, you will be asked for a
 transcript file to use.  If there is no transcript file, the
 buffer name will be like *R* or *R2*, determined by
 `ess-gen-proc-buffer-name-function'.
 
 Takes the program name from the variable `inferior-ess-program'.
-Arguments to `inferior-ess-program' can be given with
-`inferior-ess-start-args'.
 
 See Info node `(ess)Customizing startup' and
 `display-buffer-alist' to control where and how the buffer is
@@ -180,33 +177,31 @@ This may be useful for debugging."
         ;; TODO: Get rid of this, we should rely on modes to set the
         ;; variables they need.
         (ess-setq-vars-local ess-customize-alist)
-        (let ((inf-args (or ess-start-args
-                            inferior-ess-start-args)))
-          (inferior-ess--set-major-mode ess-dialect)
-          ;; Show the buffer
-          ;; TODO: Remove inferior-ess-own-frame after ESS 19.04, then just have:
-          ;; (pop-to-buffer inf-buf)
-          (pop-to-buffer inf-buf (with-no-warnings
-                                   (when inferior-ess-own-frame
-                                     '(display-buffer-pop-up-frame))))
-          (let ((proc (inferior-ess--start-process inf-buf proc-name inf-args)))
-            (ess-make-buffer-current)
-            (goto-char (point-max))
-            (unless no-wait
-              (ess-write-to-dribble-buffer "(inferior-ess: waiting for process to start (before hook)\n")
-              (ess-wait-for-process proc nil 0.01 t))
-            (unless (and proc (eq (process-status proc) 'run))
-              (error "Process %s failed to start" proc-name))
-            (when ess-setwd-command
-              (ess-set-working-directory cur-dir))
-            (setq-local font-lock-fontify-region-function #'inferior-ess-fontify-region)
-            (setq-local ess-sl-modtime-alist nil)
-            (run-hooks 'ess-post-run-hook)
-            ;; User initialization can take some time ...
-            (unless no-wait
-              (ess-write-to-dribble-buffer "(inferior-ess 3): waiting for process after hook")
-              (ess-wait-for-process proc)))
-          inf-buf)))))
+        (inferior-ess--set-major-mode ess-dialect)
+        ;; Show the buffer
+        ;; TODO: Remove inferior-ess-own-frame after ESS 19.04, then just have:
+        ;; (pop-to-buffer inf-buf)
+        (pop-to-buffer inf-buf (with-no-warnings
+                                 (when inferior-ess-own-frame
+                                   '(display-buffer-pop-up-frame))))
+        (let ((proc (inferior-ess--start-process inf-buf proc-name start-args)))
+          (ess-make-buffer-current)
+          (goto-char (point-max))
+          (unless no-wait
+            (ess-write-to-dribble-buffer "(inferior-ess: waiting for process to start (before hook)\n")
+            (ess-wait-for-process proc nil 0.01 t))
+          (unless (and proc (eq (process-status proc) 'run))
+            (error "Process %s failed to start" proc-name))
+          (when ess-setwd-command
+            (ess-set-working-directory cur-dir))
+          (setq-local font-lock-fontify-region-function #'inferior-ess-fontify-region)
+          (setq-local ess-sl-modtime-alist nil)
+          (run-hooks 'ess-post-run-hook)
+          ;; User initialization can take some time ...
+          (unless no-wait
+            (ess-write-to-dribble-buffer "(inferior-ess 3): waiting for process after hook")
+            (ess-wait-for-process proc)))
+        inf-buf))))
 
 (defun inferior-ess--get-proc-buffer-create (name)
   "Get a process buffer, creating a new one if needed.

lisp/ess-julia.el

@@ -325,7 +325,6 @@ to look up any doc strings."
     (ess-smart-operators           . ess-r-smart-operators)
     (inferior-ess-exit-command     . "exit()\n")
     ;;harmful for shell-mode's C-a: -- but "necessary" for ESS-help?
-    (inferior-ess-start-args       . "")
     (inferior-ess-language-start   . nil)
     (ess-STERM                     . "iESS")
     (ess-editor                    . ess-r-editor)

lisp/ess-r-mode.el

@@ -381,7 +381,6 @@ To be used as part of `font-lock-defaults' keywords."
      (inferior-ess-search-list-command      . "search()\n")
      (inferior-ess-help-command             . inferior-ess-r-help-command)
      (inferior-ess-exit-command             . "q()")
-     (inferior-ess-start-args               . "")
      (ess-error-regexp-alist                . ess-r-error-regexp-alist)
      (ess-describe-object-at-point-commands . 'ess-r-describe-object-at-point-commands)
      (ess-STERM                             . "iESS")

lisp/ess-sas-d.el

@@ -307,7 +307,9 @@ Better logic needed!  (see 2 uses, in this file).")
              temp-dialect))
     (ess-SAS-pre-run-hook temp-dialect)
     (setq ess-eval-visibly-p nil)
-    (let ((inf-buf (inferior-ess)))
+    ;; FIXME: `inferior-SAS-args' is defined from
+    ;; `inferior-SAS-args-temp' in `ess-SAS-pre-run-hook'
+    (let ((inf-buf (inferior-ess inferior-SAS-args)))
       (with-current-buffer inf-buf
         (use-local-map sas-mode-local-map))
       inf-buf)))

lisp/ess-sp6-d.el

@@ -79,9 +79,7 @@
 
      (ess-directory-function           . S+-directory-function)
      (ess-setup-directory-function     . S+-setup-directory-function)
-     (inferior-ess-start-args          . inferior-S+-start-args)
-     (ess-STERM                        . "iESS")
-     )
+     (ess-STERM                        . "iESS"))
    S+common-cust-alist)
 
   "Variables to customize for S+.")
@@ -116,7 +114,7 @@ New way to do it."
   (setq ess-customize-alist S+-customize-alist)
   (ess-write-to-dribble-buffer
    (format "\n(S+): ess-dialect=%s, buf=%s\n" ess-dialect (current-buffer)))
-  (let ((inf-buf (inferior-ess)))
+  (let ((inf-buf (inferior-ess inferior-S+-start-args)))
     (ess-command ess-S+--injected-code)
     (when inferior-ess-language-start
       (ess-eval-linewise inferior-ess-language-start))

lisp/ess-stata-mode.el

@@ -83,7 +83,6 @@
     (inferior-ess-primary-prompt   . "[.:] \\|--more--") 
     (inferior-ess-secondary-prompt . "--more--")
     (comint-use-prompt-regexp      . t)
-    (inferior-ess-start-args       . inferior-STA-start-args)
     (inferior-ess-search-list-command   . "set more off\n search()\n")
     (comment-start                . "/\* ")
     (comment-end                  . " \*/")

lisp/essd-els.el

@@ -39,9 +39,13 @@
 (require 'ess-stata-mode)
 (require 'ess-trns)
 (require 'ess-utils)
+
+;; Easily changeable in a user's .emacs
 (defvar S+elsewhere-dialect-name "S+6"
   "Name of 'dialect' for S-PLUS at another location.")
-                                        ;easily changeable in a user's .emacs
+
+(defvar S+elsewhere-start-args "-i"
+  "Arguments for `S+elsewhere-dialect-name'.")
 
 (defcustom inferior-ess-remote-pager nil
   "Remote pager to use for reporting help files and similar things.
@@ -57,7 +61,6 @@ The default value is nil."
      (ess-object-name-db-file           . "ess-spelsewhere-namedb.el" )
      (inferior-ess-program              . inferior-S-elsewhere-program)
      (inferior-ess-help-command         . "help(\"%s\", pager=\"cat\", window=F)\n")
-     (inferior-ess-start-args           . "-i")
      (ess-STERM  . "iESS")
      )
    S+common-cust-alist)
@@ -71,7 +74,7 @@ The default value is nil."
   (ess-write-to-dribble-buffer
    (format "\n(S+elsewhere): ess-dialect=%s, buf=%s\n" ess-dialect
            (current-buffer)))
-  (let ((inf-buf (inferior-ess)))
+  (let ((inf-buf (inferior-ess S+elsewhere-start-args)))
     (when inferior-ess-language-start
       (ess-eval-linewise inferior-ess-language-start))
     inf-buf))