Skip to content

Commit 68f2caa

Browse files
committed
dap-python.el: fix byte-compile warnings
- cl-defstruct's :type paramter should not be in parens - `dap-python--populate-test-at-point' called (conf) as a function dap-mode now builds cleanly: `cask build`
1 parent 9648a97 commit 68f2caa

File tree

1 file changed

+11
-11
lines changed

1 file changed

+11
-11
lines changed

dap-python.el

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -49,10 +49,10 @@ For example you may set it to `xterm -e' which will pop xterm console when you a
4949
:type 'string)
5050

5151
(defun dap-python--pyenv-executable-find (command)
52-
"Find executable taking pyenv shims into account.
52+
"Find executable COMMAND, taking pyenv shims into account.
5353
If the executable is a system executable and not in the same path
54-
as the pyenv version then also return nil. This works around https://github.com/pyenv/pyenv-which-ext
55-
"
54+
as the pyenv version then also return nil. This works around
55+
https://github.com/pyenv/pyenv-which-ext."
5656
(if (executable-find "pyenv")
5757
(progn
5858
(let ((pyenv-string (shell-command-to-string (concat "pyenv which " command)))
@@ -71,17 +71,17 @@ as the pyenv version then also return nil. This works around https://github.com/
7171
(executable-find command)))
7272

7373
(cl-defstruct dap-python--point
74-
(line (:type integer) :named t)
75-
(character (:type integer) :named t))
74+
(line nil :type integer :named t)
75+
(character nil :type integer :named t))
7676

7777
(cl-defstruct dap-python--location
78-
(start (:type dap-python--point) :named t)
79-
(end (:type dap-python--point) :named t))
78+
(start nil :type dap-python--point :named t)
79+
(end nil :type dap-python--point :named t))
8080

8181
(cl-defstruct dap-python--symbol
82-
(name (:type string) :named t)
83-
(type (:type string) :named t)
84-
(location (:type dap-python--location) :named t))
82+
(name nil :type string)
83+
(type nil :type string)
84+
(location nil :type dap-python--location))
8585

8686
(cl-defgeneric dap-python--equal (lhs rhs)
8787
(:documentation "Check if lhs and rhs are equal"))
@@ -249,7 +249,7 @@ overriden in individual `dap-python' launch configurations."
249249
(dap-python--test-at-point)))
250250
(plist-put conf :cwd (lsp-workspace-root))
251251

252-
(dap-python--populate-start-file-args (conf)))
252+
(dap-python--populate-start-file-args conf))
253253

254254
(dap-register-debug-provider "python" 'dap-python--populate-start-file-args)
255255
(dap-register-debug-template "Python :: Run file (buffer)"

0 commit comments

Comments
 (0)