Drop emacs 25.x support and make posframe explicit dependency

Author: yyoncho

dap-mode.el

@@ -18,7 +18,7 @@
 ;; Author: Ivan Yonchovski <[email protected]>
 ;; Keywords: languages, debug
 ;; URL: https://github.com/yyoncho/dap-mode
-;; Package-Requires: ((emacs "25.1") (dash "2.14.1") (lsp-mode "6.0") (dash-functional "1.2.0") (bui "1.1.0") (f "0.20.0") (s "1.12.0") (lsp-treemacs "0.1"))
+;; Package-Requires: ((emacs "26.1") (dash "2.14.1") (lsp-mode "6.0") (dash-functional "1.2.0") (bui "1.1.0") (f "0.20.0") (s "1.12.0") (lsp-treemacs "0.1") (posframe "0.7.0"))
 ;; Version: 0.5
 
 ;;; Commentary:
@@ -33,6 +33,7 @@
 (require 'dap-overlays)
 (require 'cl-lib)
 (require 'ansi-color)
+(require 'posframe)
 
 (defcustom dap-breakpoints-file (expand-file-name (locate-user-emacs-file ".dap-breakpoints"))
   "Where to persist breakpoints"

dap-ui.el

@@ -35,6 +35,7 @@
 (require 'gdb-mi)
 (require 'lsp-treemacs)
 (require 'dap-ui-repl)
+(require 'posframe)
 
 (defcustom dap-ui-stack-frames-loaded nil
   "Stack frames loaded."
@@ -475,11 +476,6 @@ DEBUG-SESSION is the debug session triggering the event."
               'pointer 'hand
               'help-echo hover-text))
 
-(declare-function posframe-show "ext:posframe")
-(declare-function posframe-hide "ext:posframe")
-(declare-function posframe-poshandler-frame-top-center "ext:posframe")
-(defvar posframe-mouse-banish)
-
 (defun dap-ui--update-controls (&rest _)
   (let* ((session (dap--cur-session))
          (stopped? (and session (dap--debug-session-active-frame session)))
@@ -532,8 +528,6 @@ DEBUG-SESSION is the debug session triggering the event."
   :init-value nil
   :global t
   :require 'dap-ui
-  (unless (require 'posframe nil t)
-    (error "Displaying DAP controls requires that the posframe Emacs package is installed"))
   (cond
    (dap-ui-controls-mode
     (add-hook 'dap-session-changed-hook 'dap-ui--update-controls)