Fix Flutter widget guide lines bug

Author: ericdallo

lsp-dart-flutter-widget-guide.el

@@ -125,7 +125,9 @@ ANCHOR is the anchor point of the widget guide at LINE."
           (let ((char start-char))
             (while (<= char end-char)
               (if (= char start-char)
-                  (setf (nth char chars) lsp-dart-flutter-widget-guide-bottom-corner)
+                  (if (nth char chars)
+                      (setf (nth char chars) lsp-dart-flutter-widget-guide-bottom-corner)
+                    (setq chars (append chars (list lsp-dart-flutter-widget-guide-bottom-corner))))
                 (if (nth char chars)
                     (setf (nth char chars) lsp-dart-flutter-widget-guide-horizontal-line)
                   (setq chars (append chars (list lsp-dart-flutter-widget-guide-horizontal-line)))))
@@ -156,5 +158,20 @@ ANCHOR is the anchor point of the widget guide at LINE."
              (--each-indexed chars (lsp-dart-flutter-widget-guide--add-overlay-to buffer line (+ it-index anchor) it))))
          guides-by-line)))))
 
+(define-minor-mode lsp-dart-flutter-widget-guides-mode
+  "Mode for displaying flutter widget guide lines."
+  nil nil nil
+  (cond
+   (lsp-dart-flutter-widget-guides-mode
+    (add-hook 'lsp-dart-outline-arrived-hook #'lsp-dart-flutter-widget-guide-check nil t))
+   (t
+    (progn
+      (remove-overlays (point-min) (point-max) 'category 'lsp-dart-flutter-widget-guide)
+      (remove-hook 'lsp-dart-outline-arrived-hook #'lsp-dart-flutter-widget-guide-check t)))))
+
+(add-hook 'lsp-before-open-hook (lambda ()
+                                  (when lsp-dart-flutter-widget-guides
+                                    (lsp-dart-flutter-widget-guides-mode 1))))
+
 (provide 'lsp-dart-flutter-widget-guide)
 ;;; lsp-dart-flutter-widget-guide.el ends here

lsp-dart-outline.el

@@ -24,7 +24,6 @@
 (require 'lsp-dart-protocol)
 (require 'lsp-dart-utils)
 (require 'lsp-dart-code-lens)
-(require 'lsp-dart-flutter-widget-guide)
 
 (defcustom lsp-dart-outline t
   "Enable the analysis server outline custom method.
@@ -225,8 +224,7 @@ It updates the outline view if it already exists."
 NOTIFICATION is Flutter outline notification data received from server.
 It updates the Flutter outline view if it already exists."
   (lsp-dart-outline--set-metadata workspace notification "current-flutter-outline")
-  (when lsp-dart-flutter-widget-guides
-    (lsp-dart-flutter-widget-guide-check notification))
+  (run-hook-with-args 'lsp-dart-outline-arrived-hook notification)
   (when (get-buffer-window "*Flutter Outline*")
     (lsp-dart-outline--show-flutter-outline (find-buffer-visiting (lsp--uri-to-path uri)) t)))
 

lsp-dart.el

@@ -34,6 +34,7 @@
 (require 'lsp-dart-closing-labels)
 (require 'lsp-dart-outline)
 (require 'lsp-dart-flutter-fringe)
+(require 'lsp-dart-flutter-widget-guide)
 
 (defgroup lsp-dart nil
   "LSP support for Dart, using dart analysis server."