Skip to content

Commit 17450c5

Browse files
committed
Fix tests
1 parent a5baaa1 commit 17450c5

File tree

4 files changed

+20
-109
lines changed

4 files changed

+20
-109
lines changed

features/OrganizeImports.feature

Lines changed: 0 additions & 93 deletions
This file was deleted.

features/step-definitions/lsp-java-steps.el

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -79,8 +79,7 @@
7979
(And "^I add project \"\\([^\"]+\\)\" folder \"\\([^\"]+\\)\" to the list of workspace folders$"
8080
(lambda (project dir-name)
8181
(mkdir lsp-java-workspace-dir t)
82-
(lsp--persist (f-join lsp-java-workspace-dir ".folders")
83-
(list (f-join lsp-java-test-root dir-name project)))))
82+
(lsp-workspace-folders-add (f-join lsp-java-test-root dir-name project))))
8483

8584
(And "^I start lsp-java$"
8685
(lambda () (lsp)))
@@ -89,11 +88,8 @@
8988
(lambda (status callback)
9089
(lsp-java-steps-async-wait
9190
(lambda ()
92-
(if (s-equals? (s-trim (lsp-mode-line)) status)
93-
t
94-
(progn
95-
(message "Server status is %s" (lsp-mode-line))
96-
nil)))
91+
(--some? (equal (lsp--workspace-status-string it) "::Started")
92+
(lsp--session-workspaces (lsp-session))))
9793
callback)))
9894

9995
(And "^I use formatter profile \"\\([^\"]+\\)\" from \"\\([^\"]+\\)\"$"

features/support/env.el

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,8 @@
2727
(require 'lsp-java))
2828

2929
(Setup
30-
(lsp-java-update-server))
30+
(unless (file-directory-p (expand-file-name "plugins" lsp-java-server-install-dir))
31+
(lsp-java-update-server)))
3132

3233
(Before
3334
(require 'lsp-java)
@@ -39,7 +40,8 @@
3940
lsp-java-server-install-dir (locate-user-emacs-file "eclipse.jdt.ls/server/")
4041
lsp-response-timeout 30)
4142
(when (file-exists-p lsp-java-test-root)
42-
(delete-directory lsp-java-test-root t)))
43+
(delete-directory lsp-java-test-root t))
44+
(setq lsp--session (make-lsp-session)))
4345

4446
(After
4547
(mapc 'kill-buffer

lsp-java.el

Lines changed: 13 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -664,11 +664,17 @@ server."
664664

665665
(defun lsp-java--find-project-uri (file-uri)
666666
"Return the java project corresponding FILE-URI."
667-
(->> (lsp--uri-to-path file-uri)
668-
(lsp-find-workspace 'jdtls)
669-
lsp-java--get-project-uris
670-
(--filter (s-starts-with? (lsp--uri-to-path it) (lsp--uri-to-path file-uri)))
671-
(--max-by (> (length it) (length other)))))
667+
(let ((workspace (lsp-java--current-workspace-or-lose))
668+
(session-folder (lsp-find-session-folder (lsp-session) (buffer-file-name))))
669+
(with-lsp-workspace workspace
670+
;; look for a maven nested project or fallback to the session folder root.
671+
(let ((project-folder (or (->> session-folder
672+
lsp--path-to-uri
673+
(lsp-send-execute-command "che.jdt.ls.extension.mavenProjects")
674+
(--filter (f-ancestor-of? (lsp--uri-to-path (file-name-as-directory it)) buffer-file-name))
675+
(--max-by (> (length it) (length other))))
676+
(lsp--path-to-uri (file-name-as-directory session-folder)))))
677+
project-folder))))
672678

673679
(defun lsp-java--nearest-widget ()
674680
"Return widget at point or next nearest widget."
@@ -682,7 +688,7 @@ server."
682688
(defun lsp-java--tree-under-cursor ()
683689
"Get tree under cursor."
684690
(-when-let (widget-under-cursor (lsp-java--nearest-widget))
685-
(if (tree-widget-p widget-under-cursor )
691+
(if (tree-widget-p widget-under-cursor)
686692
widget-under-cursor
687693
(widget-get widget-under-cursor :parent))))
688694

@@ -877,7 +883,7 @@ PROJECT-URI uri of the item."
877883
(buffer-string))))))
878884
:initialized-fn (lambda (workspace)
879885
(with-lsp-workspace workspace
880-
(lsp-java-update-project-uris)))))
886+
(lsp-java-update-user-settings)))))
881887

882888
(defun lsp-java-spring-initializr ()
883889
"Emacs frontend for https://start.spring.io/."

0 commit comments

Comments
 (0)