lsp-execute-command': use make-obsolete'

The proper way to mark a function as deprecated is to use
`make-obsolete'; use that instead of `lsp--warn'.

Author: nbfalcon

lsp-mode.el

@@ -1089,7 +1089,8 @@ calling `remove-overlays'.")
 (defvar-local lsp--virtual-buffer-point-max nil)
 
 (cl-defgeneric lsp-execute-command (server command arguments)
-  "Ask SERVER to execute COMMAND with ARGUMENTS.")
+  "Ask SERVER to execute COMMAND with ARGUMENTS."
+  (declare (obsolete "use `make-lsp-client' with :action-handlers instead." "7.1.0")))
 
 (defun lsp-elt (sequence n)
   "Return Nth element of SEQUENCE or nil if N is out of range."
@@ -5177,8 +5178,7 @@ It will show up only if current point has signature help."
                         (lsp--workspace-client)
                         (lsp--client-server-id))))
     (condition-case nil
-        (prog1 (lsp-execute-command server-id (intern command) arguments?)
-          (lsp--warn "`lsp-execute-command' is deprecated"))
+        (lsp-execute-command server-id (intern command) arguments?)
       (cl-no-applicable-method
        (if-let ((action-handler (lsp--find-action-handler command)))
            (funcall action-handler action)