Skip to content

Fix PHP Language Server detection #4508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix PHP Language Server detection #4508

wants to merge 1 commit into from

Conversation

AlexanderSeto
Copy link

Currently, if lsp-clients-php-server-command is not set, the test-command for the PHP Language Server (php-ls) will return as true. This results in php-ls appearing in the list of available servers even if not installed. This commit fixes the check to return false when not set.

Closes #4507

@github-actions github-actions bot added documentation client One or more of lsp-mode language clients labels Jul 27, 2024
@jcs090218
Copy link
Member

I'm a little confused. Since the function holds lambda, does that mean the result won't be accurate? 🤔

@AlexanderSeto
Copy link
Author

I apologize, I'm not entirely sure I follow what you mean.

Currently, if lsp-clients-php-server-command is not initially set, the condition evaluates to nil, and so the lambda returns t. This means lsp will present php-ls in the list of available servers despite it not existing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcs090218 jcs090218 jcs090218 approved these changes

Assignees
No one assigned
Labels
client One or more of lsp-mode language clients documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test command for PHP Language Server returns true when lsp-clients-php-server-command is nil.
2 participants
@AlexanderSeto @jcs090218