Skip to content

Improve lsp--buffer-string-visible performance, avoide headvy generate-new-buffer #4794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Improve lsp--buffer-string-visible performance, avoide headvy generate-new-buffer #4794

wants to merge 1 commit into from

Conversation

eval-exec
Copy link
Contributor

  • I added a new entry to CHANGELOG.md

  • I updated documentation if applicable (docs folder)

@eval-exec eval-exec force-pushed the exec/improve-lsp--buffer-string-visible-performance branch from 3ab1722 to 2aa37ec Compare May 24, 2025 09:13
@eval-exec eval-exec marked this pull request as ready for review May 24, 2025 09:14
@kiennq
Copy link
Member

kiennq commented May 26, 2025

Do you have a benchmark for the perf improvement?
I think the concat is degrading the performance more than insert + generate-new-buffer though. A nit performance improvement over the current code is passing inhibit-hooks for generate-new-buffer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eval-exec @kiennq