Fix CI tests: download SonarLint before testing

Author: necto

Makefile

@@ -5,9 +5,9 @@ EASK ?= eask
 
 TEST-FILES := $(shell ls test/*.el)
 
-.PHONY: clean checkdoc lint package install compile test
+.PHONY: clean checkdoc lint package install compile download-sonarlint test
 
-ci: clean package install compile test
+ci: clean package install compile download-sonarlint test
 
 package:
 	@echo "Packaging..."
@@ -21,6 +21,10 @@ compile:
 	@echo "Compiling..."
 	$(EASK) compile
 
+download-sonarlint:
+	@echo "Downloading SonarLint..."
+	$(EASK) eval '(progn (require (quote lsp-sonarlint)) (lsp-sonarlint-download))'
+
 test:
 	@echo "Testing..."
 	$(EASK) test ert $(TEST-FILES)

test/lsp-sonarlint-integration-test.el

@@ -28,6 +28,15 @@
 (require 'lsp-mode)
 (require 'lsp-sonarlint)
 
+(ert-deftest lsp-sonarlint-plugin-downloaded ()
+  "Check whether you have downloaded SonarLint.
+
+This is a prerequisite for all the integration tests. If this
+test fails, you need to download the SonarLint plugin using
+
+make download-sonarlint"
+  (should (file-exists-p (concat lsp-sonarlint-download-dir "/extension/server/sonarlint-ls.jar"))))
+
 (defun lsp-sonarlint--wait-for (predicate hook timeout)
   "Register PREDICATE to run on HOOK, and wait until it returns t.
 If that does not occur before TIMEOUT, throw an error."
@@ -72,7 +81,6 @@ only works for specific textDocument/didOpen:languageId."
         (lsp-enable-snippet nil)
         received-warnings)
     (let ((buf (find-file-noselect file))
-          (lsp-sonarlint-plugin-autodownload t)
           (diagnostics-updated nil)
           (register-warning (lambda (&rest w) (when (equal (car w) 'lsp-mode)
                                            (push (cadr w) received-warnings)))))