Skip to content

YAML syntax highlighting changes? #610

@jimeh

Description

@jimeh

Commit 9c3c77d changed syntax highlight colors for keys in YAML files. And I'm just curious as to what the underlying reason for this change was.

While the old query marked the key nodes as @variable, it was to retain as close as possibly syntax highlighting to yaml-mode without tree-sitter, so as to not feel like too drastic of a change when enabling tree-sitter-mode.

Screenshots

Here's a few screenshots demonstrating how 9c3c77d has affected things:

After commit 9c3c77d

Screenshot 2024-05-12 at 22 13 22

Before commit 9c3c77d

Screenshot 2024-05-12 at 22 13 37

yaml-mode without tree-sitter-mode

Screenshot 2024-05-12 at 22 13 49

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions