Fixed issue where original params was being modified

Author: jclusso

lib/client.js

@@ -10,13 +10,12 @@ class Client {
   }
 
   makeGetRequest(endpoint, params = {}) {
-    const key = params.apiKey || params.accessToken || this.apiKey
+    const { apiKey, accessToken, ...filteredParams } = params
+    const key = apiKey || accessToken || this.apiKey
     const headers = key ? { Authorization: `Bearer ${key}` } : {}
-    delete params.apiKey
-    delete params.accessToken
 
     return new Promise((resolve, reject) => {
-      this.instance.get(endpoint, { params: params, headers: headers })
+      this.instance.get(endpoint, { params: filteredParams, headers: headers })
         .then(response => resolve(response.data))
         .catch(error => {
           if (error.response) {
@@ -32,13 +31,12 @@ class Client {
   }
 
   makePostRequest(endpoint, data = {}) {
-    const key = data.apiKey || data.accessToken || this.apiKey
+    const { apiKey, accessToken, ...filteredData } = data
+    const key = apiKey || accessToken || this.apiKey
     const headers = key ? { Authorization: `Bearer ${key}` } : {}
-    delete data.apiKey
-    delete data.accessToken
 
     return new Promise((resolve, reject) => {
-      this.instance.post(endpoint, data, { headers: headers})
+      this.instance.post(endpoint, filteredData, { headers: headers})
         .then(response => resolve(response.data))
         .catch(error => {
           reject({

test/authentication.spec.js

@@ -82,4 +82,21 @@ describe('authentication', () => {
       .catch(done)
   })
 
+  it('should not modify the original params object passed in', done => {
+    const emailable = require('../lib/emailable')()
+    const params = { apiKey: apiKey }
+
+    Promise.all([
+      emailable.verify(email, params).then((a,b,c) => {
+        expect(params.apiKey).to.equal(apiKey)
+      }),
+
+      emailable.account(params).then(() => {
+        expect(params.apiKey).to.equal(apiKey)
+      })
+    ])
+      .then(() => done())
+      .catch(done)
+  })
+
 })