Dropping use of _.values to iterate for waking workers

Author: eman2673

features/parallel_custom_assign.feature

@@ -94,8 +94,13 @@ Feature: Running scenarios in parallel with custom assignment
       function step_def(name, delay) {
         return function(scenario, cb) {
           if (worker == null) worker = name;
-          expect(worker).to.eq(name)
-          expect(scenario).to.eq(++processed)
+          if (processed !== 3) {
+            expect(worker).to.eq(name)
+            expect(scenario).to.eq(++processed)
+          } else {
+            // Scenario 3 might get picked up by B as both are ready at this point
+            expect(scenario).to.eq(processed++)
+          }
           setTimeout(cb, delay)
         }
       }
@@ -114,6 +119,10 @@ Feature: Running scenarios in parallel with custom assignment
         Scenario: 2
           Given scenario complex 2
 
+        @complex
+        Scenario: 3
+          Given scenario complex 3
+
         @simple
         Scenario: 4
           Given scenario simple 1

src/runtime/parallel/coordinator.ts

@@ -101,7 +101,7 @@ export default class Coordinator {
       this.saveDefinitionIdMapping(message.supportCodeIds)
     } else if (message.ready) {
       worker.state = WorkerState.idle
-      this.awakenWorkers()
+      this.awakenWorkers(worker)
     } else if (doesHaveValue(message.jsonEnvelope)) {
       const envelope = messages.Envelope.fromObject(
         JSON.parse(message.jsonEnvelope)
@@ -158,17 +158,16 @@ export default class Coordinator {
     }
   }
 
-  awakenWorkers(): void {
-    const workers = _.values(this.workers)
-    _.each(workers, (worker): boolean => {
+  awakenWorkers(triggeringWorker: IWorker): void {
+    _.each(this.workers, (worker): boolean => {
       if (worker.state === WorkerState.idle) {
         this.giveWork(worker)
       }
       return worker.state !== WorkerState.idle
     })
 
     if (_.isEmpty(this.inProgressPickles) && this.pickleIds.length > 0) {
-      this.giveWork(workers[0], true)
+      this.giveWork(triggeringWorker, true)
       this.idleInterventions++
     }
   }