Moving idle state to worker ready message

Defaulting state to new

Author: eman2673

features/parallel_custom_assign.feature

@@ -1,17 +1,20 @@
-Feature: Running scenarios in parallel
+Feature: Running scenarios in parallel with custom assignment
 
   Scenario: Bad parallel assignment helper uses 1 worker
     Given a file named "features/step_definitions/cucumber_steps.js" with:
       """
       const {Then, setParallelCanAssign} = require('@cucumber/cucumber')
-      const assert = require('assert')
+      const {expect} = require('chai')
       let value = 0;
       setParallelCanAssign(() => false)
-      Then(/^value is (\d+)$/, function(v) { assert(++value === v) })
+      Then(/^value is (\d+)$/, function(v, cb) {
+        expect(++value).to.eq(v)
+         setTimeout(cb, 150)
+      })
       """
     And a file named "features/a.feature" with:
       """
-      Feature: no processing
+      Feature: only one worker works
         Scenario: someone must do work
           Then value is 1
 
@@ -25,14 +28,17 @@ Feature: Running scenarios in parallel
     Given a file named "features/step_definitions/cucumber_steps.js" with:
       """
       const {Then, setParallelCanAssign} = require('@cucumber/cucumber')
-      const assert = require('assert')
+      const {expect} = require('chai')
       let value = 0;
       setParallelCanAssign(() => true)
-      Then(/^value is (\d+)$/, function(v) { assert(++value === v) })
+      Then(/^value is (\d+)$/, function(v, cb) {
+        expect(++value).to.eq(v)
+         setTimeout(cb, 150)
+      })
       """
     And a file named "features/a.feature" with:
       """
-      Feature: no processing
+      Feature: separate worker for each scenario
         Scenario: a
           Then value is 1
 
@@ -55,7 +61,7 @@ Feature: Running scenarios in parallel
       """
     And a file named "features/a.feature" with:
       """
-      Feature: slow
+      Feature: adheres to setParallelCanAssign handler
         Scenario: a
           Given scenario 1
 

src/runtime/parallel/coordinator.ts

@@ -37,6 +37,7 @@ const enum WorkerState {
   'idle',
   'closed',
   'running',
+  'new',
 }
 
 interface IWorker {
@@ -99,6 +100,7 @@ export default class Coordinator {
     if (doesHaveValue(message.supportCodeIds)) {
       this.saveDefinitionIdMapping(message.supportCodeIds)
     } else if (message.ready) {
+      worker.state = WorkerState.idle
       this.awakenWorkers()
     } else if (doesHaveValue(message.jsonEnvelope)) {
       const envelope = messages.Envelope.fromObject(
@@ -109,7 +111,6 @@ export default class Coordinator {
         this.remapDefinitionIds(envelope.testCase)
       }
       if (doesHaveValue(envelope.testCaseFinished)) {
-        worker.state = WorkerState.idle
         this.inProgressPickles = _.omit(this.inProgressPickles, worker.id)
         this.parseTestCaseResult(envelope.testCaseFinished)
       }
@@ -177,7 +178,7 @@ export default class Coordinator {
       }),
       stdio: ['inherit', 'inherit', 'inherit', 'ipc'],
     })
-    const worker = { state: WorkerState.idle, process: workerProcess, id }
+    const worker = { state: WorkerState.new, process: workerProcess, id }
     this.workers[id] = worker
     worker.process.on('message', (message: ICoordinatorReport) => {
       this.parseWorkerMessage(worker, message)