Skip to content

Commit 0191ec9

Browse files
webserver -- canonicalHost, defaultHost, dockerHostSwap
1 parent d70264a commit 0191ec9

File tree

2 files changed

+12
-4
lines changed

2 files changed

+12
-4
lines changed

lib/modules/webserver/index.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
var {canonicalHost} = require('../../utils/host.js');
12
var utils = require('../../utils/utils.js');
23
var Server = require('./server.js');
34

@@ -26,7 +27,7 @@ class WebServer {
2627
}
2728

2829
setServiceCheck() {
29-
let url = 'http://' + this.host + ':' + this.port;
30+
let url = 'http://' + canonicalHost(this.host) + ':' + this.port;
3031

3132
this.events.request("services:register", 'Webserver', function (cb) {
3233
utils.checkIsAvailable(url, function (available) {

lib/modules/webserver/server.js

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,23 @@
11
let finalhandler = require('finalhandler');
22
let http = require('http');
33
let serveStatic = require('serve-static');
4+
const {canonicalHost, defaultHost, dockerHostSwap} = require('../../utils/host');
45
require('http-shutdown').extend();
56

67
class Server {
78
constructor(options) {
89
this.dist = options.dist || 'dist/';
910
this.port = options.port || 8000;
10-
this.hostname = options.host || 'localhost';
11+
this.hostname = dockerHostSwap(options.host) || defaultHost;
1112
this.logger = options.logger;
1213
}
1314

1415
start(callback) {
1516
if (this.server && this.server.listening) {
16-
this.logger.warn(__("a webserver is already running at") + " " + ("http://" + this.hostname + ":" + this.port).bold.underline.green);
17+
this.logger.warn(__("a webserver is already running at") +
18+
" " +
19+
("http://" + canonicalHost(this.hostname) +
20+
":" + this.port).bold.underline.green);
1721
if (callback) {
1822
callback();
1923
}
@@ -25,7 +29,10 @@ class Server {
2529
serve(req, res, finalhandler(req, res));
2630
}).withShutdown();
2731

28-
this.logger.info(__("webserver available at") + " " + ("http://" + this.hostname + ":" + this.port).bold.underline.green);
32+
this.logger.info(__("webserver available at") +
33+
" " +
34+
("http://" + canonicalHost(this.hostname) +
35+
":" + this.port).bold.underline.green);
2936
this.server.listen(this.port, this.hostname);
3037
if (callback) {
3138
callback();

0 commit comments

Comments
 (0)