Skip to content

Commit 114bf7f

Browse files
authored
Merge pull request #366 from embark-framework/bug_fix/fix-ready-printed-before-complete
Moved console "ready" message to write after outputDone event is emitted
2 parents ad13680 + a3d2cc9 commit 114bf7f

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

lib/index.js

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -118,6 +118,11 @@ class Embark {
118118
});
119119
});
120120

121+
engine.events.on('outputDone', function () {
122+
engine.logger.info("Looking for documentation? You can find it at ".cyan + "http://embark.readthedocs.io/".green.underline + ".".cyan);
123+
engine.logger.info("Ready".underline);
124+
});
125+
121126
engine.deployManager.deployContracts(function (err) {
122127
engine.startService("fileWatcher");
123128
if (options.runWebserver) {
@@ -136,8 +141,6 @@ class Embark {
136141
} else {
137142
engine.events.emit('firstDeploymentDone');
138143
engine.events.emit("status", "Ready".green);
139-
engine.logger.info("Looking for documentation? you can find it at ".cyan + "http://embark.readthedocs.io/".green.underline);
140-
engine.logger.info("Ready".underline);
141144

142145
let size = windowSize.get();
143146
if (size.height < 40 || size.width < 118) {
@@ -249,7 +252,6 @@ class Embark {
249252
resetCmd();
250253
}
251254

252-
// TODO: should deploy if it hasn't already
253255
upload(platform, options) {
254256

255257
options.buildDir = 'dist/';

0 commit comments

Comments
 (0)