Skip to content

Commit 8c1b9b5

Browse files
committed
update bundle; don't double add shh option
1 parent 3b4e5f5 commit 8c1b9b5

File tree

2 files changed

+28
-28
lines changed

2 files changed

+28
-28
lines changed

js/build/embark.bundle.js

Lines changed: 25 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -43,9 +43,6 @@ return /******/ (function(modules) { // webpackBootstrap
4343
/******/ // expose the module cache
4444
/******/ __webpack_require__.c = installedModules;
4545
/******/
46-
/******/ // identity function for calling harmony imports with the correct context
47-
/******/ __webpack_require__.i = function(value) { return value; };
48-
/******/
4946
/******/ // define getter function for harmony exports
5047
/******/ __webpack_require__.d = function(exports, name, getter) {
5148
/******/ if(!__webpack_require__.o(exports, name)) {
@@ -100,6 +97,7 @@ EmbarkJS.isNewWeb3 = function() {
10097
EmbarkJS.Contract = function(options) {
10198
var self = this;
10299
var i, abiElement;
100+
var ContractClass;
103101

104102
this.abi = options.abi;
105103
this.address = options.address;
@@ -110,14 +108,12 @@ EmbarkJS.Contract = function(options) {
110108
// TODO:
111109
// add default **from** address
112110
// add gasPrice
113-
var ContractClass = new this.web3.eth.Contract(this.abi, this.address);
111+
ContractClass = new this.web3.eth.Contract(this.abi, this.address);
114112
ContractClass.setProvider(this.web3.currentProvider);
115113

116114
return ContractClass;
117115
} else {
118-
119-
120-
var ContractClass = this.web3.eth.contract(this.abi);
116+
ContractClass = this.web3.eth.contract(this.abi);
121117

122118
this.eventList = [];
123119

@@ -444,7 +440,7 @@ EmbarkJS.Messages.setProvider = function(provider, options) {
444440
var self = this;
445441
var ipfs;
446442
if (provider === 'whisper') {
447-
this.providerName = 'whisper'
443+
this.providerName = 'whisper';
448444
this.currentMessages = EmbarkJS.Messages.Whisper;
449445
let provider;
450446
if (options === undefined) {
@@ -473,7 +469,7 @@ EmbarkJS.Messages.setProvider = function(provider, options) {
473469
self.currentMessages.whisperVersion = self.currentMessages.web3.version.whisper;
474470
});
475471
} else if (provider === 'orbit') {
476-
this.providerName = 'orbit'
472+
this.providerName = 'orbit';
477473
this.currentMessages = EmbarkJS.Messages.Orbit;
478474
if (options === undefined) {
479475
ipfs = HaadIpfsApi('localhost', '5001');
@@ -502,11 +498,12 @@ EmbarkJS.Messages.listenTo = function(options) {
502498
EmbarkJS.Messages.Whisper = {};
503499

504500
EmbarkJS.Messages.Whisper.sendMessage = function(options) {
501+
var topics, data, ttl, priority, payload;
505502
if (EmbarkJS.Messages.isNewWeb3()) {
506-
var topics = options.topic || options.topics;
507-
var data = options.data || options.payload;
508-
var ttl = options.ttl || 100;
509-
var priority = options.priority || 1000;
503+
topics = options.topic || options.topics;
504+
data = options.data || options.payload;
505+
ttl = options.ttl || 100;
506+
priority = options.priority || 1000;
510507
var powTime = options.powTime || 3;
511508
var powTarget = options.powTarget || 0.5;
512509

@@ -520,7 +517,7 @@ EmbarkJS.Messages.Whisper.sendMessage = function(options) {
520517

521518
topics = this.web3.utils.toHex(topics).slice(0, 10);
522519

523-
var payload = JSON.stringify(data);
520+
payload = JSON.stringify(data);
524521

525522
let message = {
526523
symKeyID: this.symKeyID, // encrypts using the sym key ID
@@ -534,11 +531,11 @@ EmbarkJS.Messages.Whisper.sendMessage = function(options) {
534531

535532
this.web3.shh.post(message, function() { });
536533
} else {
537-
var topics = options.topic || options.topics;
538-
var data = options.data || options.payload;
534+
topics = options.topic || options.topics;
535+
data = options.data || options.payload;
536+
ttl = options.ttl || 100;
537+
priority = options.priority || 1000;
539538
var identity = options.identity || this.identity || web3.shh.newIdentity();
540-
var ttl = options.ttl || 100;
541-
var priority = options.priority || 1000;
542539
var _topics;
543540

544541
if (topics === undefined) {
@@ -556,7 +553,7 @@ EmbarkJS.Messages.Whisper.sendMessage = function(options) {
556553
}
557554
topics = _topics;
558555

559-
var payload = JSON.stringify(data);
556+
payload = JSON.stringify(data);
560557

561558
var message;
562559
message = {
@@ -567,13 +564,14 @@ EmbarkJS.Messages.Whisper.sendMessage = function(options) {
567564
priority: priority
568565
};
569566

570-
return EmbarkJS.Messages.currentMessages.web3.shh.post(message, function() { console.log("message sent") });
567+
return EmbarkJS.Messages.currentMessages.web3.shh.post(message, function() { });
571568
}
572569
};
573570

574571
EmbarkJS.Messages.Whisper.listenTo = function(options) {
572+
var topics, _topics, messageEvents;
575573
if (EmbarkJS.Messages.isNewWeb3()) {
576-
var messageEvents = function() {
574+
messageEvents = function() {
577575
this.cb = function() {};
578576
};
579577

@@ -589,8 +587,8 @@ EmbarkJS.Messages.Whisper.listenTo = function(options) {
589587
this.filter.stopWatching();
590588
};
591589

592-
var topics = options.topic || options.topics;
593-
var _topics = [];
590+
topics = options.topic || options.topics;
591+
_topics = [];
594592

595593
let promise = new messageEvents();
596594

@@ -621,10 +619,10 @@ EmbarkJS.Messages.Whisper.listenTo = function(options) {
621619

622620
return promise;
623621
} else {
624-
var topics = options.topic || options.topics;
625-
var _topics = [];
622+
topics = options.topic || options.topics;
623+
_topics = [];
626624

627-
var messageEvents = function() {
625+
messageEvents = function() {
628626
this.cb = function() {};
629627
};
630628

@@ -673,7 +671,7 @@ EmbarkJS.Messages.Whisper.listenTo = function(options) {
673671

674672
return promise;
675673
}
676-
}
674+
};
677675

678676
EmbarkJS.Messages.Orbit = {};
679677

lib/cmds/blockchain/geth_commands.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,9 @@ class GethCommands {
162162
function whisper(callback) {
163163
if (config.whisper) {
164164
rpc_api.push('shh');
165-
ws_api.push('shh');
165+
if (ws_api.indexOf('shh') === -1) {
166+
ws_api.push('shh');
167+
}
166168
return callback(null, "--shh ");
167169
}
168170
callback("");

0 commit comments

Comments
 (0)