Skip to content

Commit c093cf8

Browse files
feat: support Node.js v12.x and newer
Remove the `<12.0.0` restriction re: Node.js version in the `"engines"` settings for all the packages in the monorepo that had that restriction. Add missing `"engines"` settings in `packages/plugins/snark/package.json`. Adjust the Azure Pipelines config to include builds for Node.js v12.x and v13.x. Bump `solc` to `0.4.26` in `dapps/tests/app` and `dapps/tests/contracts`. It was discovered that older versions suffered a fatal `Maximum call stack size exceeded` error when run on Windows with Node.js v12.x or newer. Display a warning re: the bad combo (solc version + Windows + Node version) if it's detected at runtime. Adjust the root `yarn.lock` so that the `sha3` transitive dependency resolves to a newer version that is compatible with Node v13.x.
1 parent a224401 commit c093cf8

File tree

76 files changed

+110
-76
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

76 files changed

+110
-76
lines changed

azure-pipelines.yml

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@ variables:
55
YARN_CACHE_FOLDER: $(Pipeline.Workspace)/.yarn
66
ipfsVersion: '0.4.22'
77
node10: '^10.17.0'
8+
node12: '^12.0.0'
9+
node13: '^13.0.0'
810
pythonVersion: '2.7.x'
911
yarnVersion: '1.19.1'
1012

@@ -19,6 +21,24 @@ strategy:
1921
Node 10 / Windows:
2022
nodeVersion: $(node10)
2123
imageName: 'vs2017-win2016'
24+
Node 12 / Linux:
25+
nodeVersion: $(node12)
26+
imageName: 'ubuntu-18.04'
27+
Node 12 / macOS:
28+
nodeVersion: $(node12)
29+
imageName: 'macos-10.14'
30+
Node 12 / Windows:
31+
nodeVersion: $(node12)
32+
imageName: 'vs2017-win2016'
33+
Node 13 / Linux:
34+
nodeVersion: $(node13)
35+
imageName: 'ubuntu-18.04'
36+
Node 13 / macOS:
37+
nodeVersion: $(node13)
38+
imageName: 'macos-10.14'
39+
Node 13 / Windows:
40+
nodeVersion: $(node13)
41+
imageName: 'vs2017-win2016'
2242

2343
pool:
2444
vmImage: $(imageName)

dapps/tests/app/embark.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
"buildDir": "dist/",
1616
"config": "config/",
1717
"versions": {
18-
"solc": "0.4.25"
18+
"solc": "0.4.26"
1919
},
2020
"plugins": {
2121
"embark-dapp-test-service": {}

dapps/tests/contracts/contracts.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"default": {
33
"versions": {
4-
"solc": "0.4.24"
4+
"solc": "0.4.26"
55
},
66
"dappConnection": [
77
"$EMBARK",

dapps/tests/contracts/embark.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
"namesystem": "ens.json"
1313
},
1414
"versions": {
15-
"solc": "0.4.24"
15+
"solc": "0.4.26"
1616
},
1717
"plugins": {
1818
}

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
"semver": "5.6.0"
1717
},
1818
"engines": {
19-
"node": ">=10.17.0 <12.0.0",
19+
"node": ">=10.17.0",
2020
"npm": ">=6.11.3",
2121
"yarn": ">=1.19.1"
2222
},

packages/cockpit/api-client/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@
5656
"rimraf": "3.0.0"
5757
},
5858
"engines": {
59-
"node": ">=10.17.0 <12.0.0",
59+
"node": ">=10.17.0",
6060
"npm": ">=6.11.3",
6161
"yarn": ">=1.19.1"
6262
}

packages/cockpit/ui/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@
120120
]
121121
},
122122
"engines": {
123-
"node": ">=10.17.0 <12.0.0",
123+
"node": ">=10.17.0",
124124
"npm": ">=6.11.3",
125125
"yarn": ">=1.19.1"
126126
}

packages/core/code-runner/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@
7474
"typescript": "3.7.2"
7575
},
7676
"engines": {
77-
"node": ">=10.17.0 <12.0.0",
77+
"node": ">=10.17.0",
7878
"npm": ">=6.11.3",
7979
"yarn": ">=1.19.1"
8080
},

packages/core/console/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@
7272
"typescript": "3.7.2"
7373
},
7474
"engines": {
75-
"node": ">=10.17.0 <12.0.0",
75+
"node": ">=10.17.0",
7676
"npm": ">=6.11.3",
7777
"yarn": ">=1.19.1"
7878
},

packages/core/core/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@
7979
"typescript": "3.7.2"
8080
},
8181
"engines": {
82-
"node": ">=10.17.0 <12.0.0",
82+
"node": ">=10.17.0",
8383
"npm": ">=6.11.3",
8484
"yarn": ">=1.19.1"
8585
}

0 commit comments

Comments
 (0)