Skip to content

Commit f417026

Browse files
committed
add deprecated warning for deprecated events
1 parent 2dc1941 commit f417026

File tree

2 files changed

+24
-3
lines changed

2 files changed

+24
-3
lines changed

lib/core/events.js

Lines changed: 23 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,32 @@
11
var EventEmitter = require('events');
22

3+
function warnIfLegacy(eventName) {
4+
const legacyEvents = ['abi-vanila', 'abi', 'abi-contracts-vanila', 'abi-vanila-deployment'];
5+
if (legacyEvents.indexOf(eventName) >= 0) {
6+
console.warn("this event is deprecated and will be removed in future versions: " + eventName);
7+
}
8+
}
9+
10+
const _on = EventEmitter.prototype.on;
11+
const _setHandler = EventEmitter.prototype.setHandler;
12+
13+
EventEmitter.prototype.on = function(requestName, cb) {
14+
warnIfLegacy(requestName);
15+
return _on.call(this, requestName, cb);
16+
};
17+
18+
EventEmitter.prototype.setHandler = function(requestName, cb) {
19+
warnIfLegacy(requestName);
20+
return _setHandler.call(this, requestName, cb);
21+
};
22+
323
EventEmitter.prototype.request = function(requestName, cb) {
4-
this.emit('request:' + requestName, cb);
24+
warnIfLegacy(requestName);
25+
return this.emit('request:' + requestName, cb);
526
};
627

728
EventEmitter.prototype.setCommandHandler = function(requestName, cb) {
8-
this.on('request:' + requestName, function(_cb) {
29+
return this.on('request:' + requestName, function(_cb) {
930
cb.call(this, _cb);
1031
});
1132
};

test_app/config/contracts.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"default": {
33
"versions": {
4-
"web3.js": "1.0.0",
4+
"web3.js": "0.20.0",
55
"solc": "0.4.11"
66
},
77
"deployment": {

0 commit comments

Comments
 (0)