Skip to content

Commit 2767b14

Browse files
committed
nrf: gpio: Fix return values for functions returning unit type - ()
1 parent 7c8f57e commit 2767b14

File tree

1 file changed

+16
-8
lines changed

1 file changed

+16
-8
lines changed

embassy-nrf/src/gpio.rs

Lines changed: 16 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -534,11 +534,13 @@ mod eh02 {
534534
type Error = Infallible;
535535

536536
fn set_high(&mut self) -> Result<(), Self::Error> {
537-
Ok(self.set_high())
537+
self.set_high();
538+
Ok(())
538539
}
539540

540541
fn set_low(&mut self) -> Result<(), Self::Error> {
541-
Ok(self.set_low())
542+
self.set_low();
543+
Ok(())
542544
}
543545
}
544546

@@ -580,11 +582,13 @@ mod eh02 {
580582
type Error = Infallible;
581583

582584
fn set_high(&mut self) -> Result<(), Self::Error> {
583-
Ok(self.set_high())
585+
self.set_high();
586+
Ok(())
584587
}
585588

586589
fn set_low(&mut self) -> Result<(), Self::Error> {
587-
Ok(self.set_low())
590+
self.set_low();
591+
Ok(())
588592
}
589593
}
590594

@@ -628,11 +632,13 @@ impl<'d> embedded_hal_1::digital::ErrorType for Output<'d> {
628632

629633
impl<'d> embedded_hal_1::digital::OutputPin for Output<'d> {
630634
fn set_high(&mut self) -> Result<(), Self::Error> {
631-
Ok(self.set_high())
635+
self.set_high();
636+
Ok(())
632637
}
633638

634639
fn set_low(&mut self) -> Result<(), Self::Error> {
635-
Ok(self.set_low())
640+
self.set_low();
641+
Ok(())
636642
}
637643
}
638644

@@ -665,11 +671,13 @@ impl<'d> embedded_hal_1::digital::InputPin for Flex<'d> {
665671

666672
impl<'d> embedded_hal_1::digital::OutputPin for Flex<'d> {
667673
fn set_high(&mut self) -> Result<(), Self::Error> {
668-
Ok(self.set_high())
674+
self.set_high();
675+
Ok(())
669676
}
670677

671678
fn set_low(&mut self) -> Result<(), Self::Error> {
672-
Ok(self.set_low())
679+
self.set_low();
680+
Ok(())
673681
}
674682
}
675683

0 commit comments

Comments
 (0)