From 7c150bcf92b6aed5b17328b9fe0c184fa8752e34 Mon Sep 17 00:00:00 2001 From: Jakob Lell Date: Sat, 1 Nov 2025 10:39:11 +0100 Subject: [PATCH 1/2] Fix setting of rp adc div register --- embassy-rp/src/adc.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/embassy-rp/src/adc.rs b/embassy-rp/src/adc.rs index d16779e017..490b0a5f94 100644 --- a/embassy-rp/src/adc.rs +++ b/embassy-rp/src/adc.rs @@ -300,7 +300,7 @@ impl<'d> Adc<'d, Async> { // start conversions and wait for dma to finish. we can't report errors early // because there's no interrupt to signal them, and inspecting every element // of the fifo is too costly to do here. - r.div().write_set(|w| w.set_int(div)); + r.div().modify(|w| w.set_int(div)); r.cs().write_set(|w| w.set_start_many(true)); dma.await; mem::drop(auto_reset); From 687f3b7f9a823c070a3fded92ca7a7c6ff29a2d4 Mon Sep 17 00:00:00 2001 From: Jakob Lell Date: Sat, 1 Nov 2025 10:56:42 +0100 Subject: [PATCH 2/2] Add changelog --- embassy-rp/CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/embassy-rp/CHANGELOG.md b/embassy-rp/CHANGELOG.md index 57ec13658d..57b742a949 100644 --- a/embassy-rp/CHANGELOG.md +++ b/embassy-rp/CHANGELOG.md @@ -15,6 +15,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - add `wait_for_alarm` and `alarm_scheduled` methods to rtc module ([#4216](https://github.com/embassy-rs/embassy/pull/4216)) - rp235x: use msplim for stack guard instead of MPU - Add reset_to_usb_boot for rp235x ([#4705](https://github.com/embassy-rs/embassy/pull/4705)) +- Fix configuration of embassy_rp adc div register ([#4815](https://github.com/embassy-rs/embassy/pull/4815)) ## 0.8.0 - 2025-08-26