typos, some (2-3) possible bugs

finalyards · finalyards · commit 3e0e2a074d95 · 2025-10-30T10:18:02.000+02:00
diff --git a/examples/apps/Cargo.toml b/examples/apps/Cargo.toml
@@ -10,10 +10,8 @@ bt-hci = { version = "0.6" }
 embassy-futures = "0.1.1"
 embassy-sync = { version = "0.7" }
 embassy-time = "0.5"
-#embedded-hal = "1.0"
 embedded-hal-async = "1.0"
 static_cell = "2"
-#embedded-io = "0.6"
 heapless = "0.9"
 rand_core = { version = "0.6", default-features = false }
 
@@ -30,8 +28,6 @@ defmt = [
     "dep:defmt",
     "trouble-host/defmt",
     "bt-hci/defmt",
-    #"embedded-io/defmt-03",
-    #"embedded-hal/defmt-03"
 ]
 log = [
     "dep:log",
diff --git a/examples/apps/src/ble_beacon.rs b/examples/apps/src/ble_beacon.rs
@@ -2,7 +2,7 @@
 //
 // A beacon is a device that advertises packets that are constantly being
 // updated to reflect the current state of the device, but usually does not
-// accept any conections. This allows broadcasting device information.
+// accept any connections. This allows broadcasting device information.
 //
 
 use bt_hci::cmd::le::*;
diff --git a/examples/nrf52/Cargo.toml b/examples/nrf52/Cargo.toml
@@ -34,13 +34,9 @@ debug = 2
 
 [patch.crates-io]
 #embassy-executor = {path = "../../../embassy/embassy-executor"}
-#embassy-time-queue-utils = {path = "../../../embassy/embassy-time-queue-utils"}
 #embassy-sync = {path = "../../../embassy/embassy-sync"}
 #embassy-futures = {path = "../../../embassy/embassy-futures"}
 #embassy-time = {path = "../../../embassy/embassy-time"}
-#embassy-time-driver = {path = "../../../embassy/embassy-time-driver"}
-#embassy-embedded-hal = {path = "../../../embassy/embassy-embedded-hal"}
-#embassy-hal-internal = {path = "../../../embassy/embassy-hal-internal"}
 nrf-sdc = { git = "https://github.com/alexmoon/nrf-sdc.git", rev = "11d5c3c"}
 nrf-mpsl = { git = "https://github.com/alexmoon/nrf-sdc.git", rev = "11d5c3c"}
 #bt-hci = { git = "https://github.com/embassy-rs/bt-hci.git", rev = "83a9e179ff019ed60abb73705f54383f89fc60fc" }
diff --git a/examples/rp-pico-2-w/Cargo.toml b/examples/rp-pico-2-w/Cargo.toml
@@ -39,16 +39,9 @@ debug = 2
 
 [patch.crates-io]
 #embassy-executor = {path = "../../../embassy/embassy-executor"}
-#embassy-nrf = {path = "../../../embassy/embassy-nrf"}
 #embassy-sync = {path = "../../../embassy/embassy-sync"}
 #embassy-futures = {path = "../../../embassy/embassy-futures"}
 #embassy-time = {path = "../../../embassy/embassy-time"}
-#embassy-time-driver = {path = "../../../embassy/embassy-time-driver"}
-#embassy-embedded-hal = {path = "../../../embassy/embassy-embedded-hal"}
-#embassy-hal-internal = {path = "../../../embassy/embassy-hal-internal"}
-#nrf-sdc = { path = "../../../nrf-sdc/nrf-sdc" }
-#nrf-mpsl = { path = "../../../nrf-sdc/nrf-mpsl" }
-#bt-hci = { path = "../../../bt-hci" }
 cyw43 = { git = "https://github.com/embassy-rs/embassy.git", rev = "faacad613ea26a28de216cf32ac4cc64f7862d4c" }
 embassy-time = { git = "https://github.com/embassy-rs/embassy.git", rev = "faacad613ea26a28de216cf32ac4cc64f7862d4c" }
 embassy-time-driver = { git = "https://github.com/embassy-rs/embassy.git", rev = "faacad613ea26a28de216cf32ac4cc64f7862d4c" }
diff --git a/examples/rp-pico-w/Cargo.toml b/examples/rp-pico-w/Cargo.toml
@@ -41,9 +41,6 @@ debug = 2
 #embassy-sync = {path = "../../../embassy/embassy-sync"}
 #embassy-futures = {path = "../../../embassy/embassy-futures"}
 #embassy-time = {path = "../../../embassy/embassy-time"}
-#embassy-time-driver = {path = "../../../embassy/embassy-time-driver"}
-#embassy-embedded-hal = {path = "../../../embassy/embassy-embedded-hal"}
-#embassy-hal-internal = {path = "../../../embassy/embassy-hal-internal"}
 #cyw43 = {path = "../../../embassy/cyw43"}
 #cyw43-pio = {path = "../../../embassy/cyw43-pio"}
 cyw43 = { git = "https://github.com/embassy-rs/embassy.git", rev = "faacad613ea26a28de216cf32ac4cc64f7862d4c" }
@@ -54,7 +51,3 @@ embassy-rp = { git = "https://github.com/embassy-rs/embassy.git", rev = "faacad6
 cyw43-pio = { git = "https://github.com/embassy-rs/embassy.git", rev = "faacad613ea26a28de216cf32ac4cc64f7862d4c" }
 embassy-sync = { git = "https://github.com/embassy-rs/embassy.git", rev = "faacad613ea26a28de216cf32ac4cc64f7862d4c" }
 embassy-futures = { git = "https://github.com/embassy-rs/embassy.git", rev = "faacad613ea26a28de216cf32ac4cc64f7862d4c" }
-#nrf-sdc = { path = "../../../nrf-sdc/nrf-sdc" }
-#nrf-mpsl = { path = "../../../nrf-sdc/nrf-mpsl" }
-#bt-hci = { path = "../../../bt-hci" }
-#bt-hci = { git = "https://github.com/embassy-rs/bt-hci.git", rev = "83a9e179ff019ed60abb73705f54383f89fc60fc" }
diff --git a/host-macros/src/ctxt.rs b/host-macros/src/ctxt.rs
@@ -31,7 +31,7 @@ impl Ctxt {
         }
     }
 
-    /// Add an error to the context object with a tokenenizable object.
+    /// Add an error to the context object with a tokenizable object.
     ///
     /// The object is used for spanning in error messages.
     pub fn error_spanned_by<A: ToTokens, T: Display>(&self, obj: A, msg: T) {
diff --git a/host/Cargo.toml b/host/Cargo.toml
@@ -26,7 +26,7 @@ embassy-sync = "0.7"
 embassy-time = "0.5"
 embassy-futures = "0.1"
 futures = { version = "0.3", default-features = false }
-heapless = "0.9"
+heapless = "0.9"  # "gatt", "security"
 trouble-host-macros = { path = "../host-macros", version = "0.3.0", optional = true }
 p256 = { version = "0.13.2", default-features = false, features = ["ecdh","arithmetic"], optional = true }
 rand_core = "0.6"
diff --git a/host/src/advertise.rs b/host/src/advertise.rs
@@ -35,7 +35,7 @@ pub enum TxPower {
     Plus20dBm = 20,
 }
 
-/// Configuriation for a single advertisement set.
+/// Configuration for a single advertisement set.
 #[derive(Debug, Clone)]
 #[cfg_attr(feature = "defmt", derive(defmt::Format))]
 pub struct AdvertisementSet<'d> {
diff --git a/host/src/att.rs b/host/src/att.rs
@@ -90,7 +90,7 @@ impl AttErrorCode {
     pub const WRITE_REQUEST_REJECTED: Self = Self { value: 0xFC };
     /// The client characteristic configuration descriptor (CCCD) is not configured according to the requirements of the profile or service
     pub const CCCD_IMPROPERLY_CONFIGURED: Self = Self { value: 0xFD };
-    /// The profile or service request could not be serviced because an operation that has been previousl triggered is still in progress
+    /// The profile or service request could not be serviced because an operation that has been previously triggered is still in progress
     pub const PROCEDURE_ALREADY_IN_PROGRESS: Self = Self { value: 0xFE };
     /// The attribute value is out of range as defined by a profile or service specification
     pub const OUT_OF_RANGE: Self = Self { value: 0xFF };
@@ -131,7 +131,7 @@ impl Display for AttErrorCode {
 
             &Self::WRITE_REQUEST_REJECTED => f.write_str("write request rejected: the write request could not be fulfilled for reasons other than permissions"),
             &Self::CCCD_IMPROPERLY_CONFIGURED => f.write_str("CCCD improperly configured: the client characteristic configuration descriptor (CCCD) is not configured according to the requirements of the profile or service"),
-            &Self::PROCEDURE_ALREADY_IN_PROGRESS => f.write_str("procedure already in progress: the profile or service request could not be serviced because an operation that has been previousl triggered is still in progress"),
+            &Self::PROCEDURE_ALREADY_IN_PROGRESS => f.write_str("procedure already in progress: the profile or service request could not be serviced because an operation that has been previously triggered is still in progress"),
             &Self::OUT_OF_RANGE => f.write_str("out of range: the attribute value is out of range as defined by a profile or service specification"),
 
             other => write!(f, "unknown error code {other}: check the most recent bluetooth spec"),
diff --git a/host/src/attribute.rs b/host/src/attribute.rs
@@ -402,7 +402,7 @@ impl<'d, M: RawMutex, const MAX: usize> AttributeTable<'d, M, MAX> {
     /// The provided data must exactly match the size of the storage for the characteristic,
     /// otherwise this function will panic.
     ///
-    /// If the characteristic for the handle cannot be found, or the shape of the data does not match the type of the characterstic,
+    /// If the characteristic for the handle cannot be found, or the shape of the data does not match the type of the characteristic,
     /// an error is returned
     pub fn set<T: AttributeHandle>(&self, attribute_handle: &T, input: &T::Value) -> Result<(), Error> {
         let gatt_value = input.as_gatt();
@@ -563,7 +563,7 @@ impl<'d, M: RawMutex, const MAX: usize> ServiceBuilder<'_, 'd, M, MAX> {
         }
     }
 
-    /// Add a characteristic to this service with a refererence to a mutable storage buffer.
+    /// Add a characteristic to this service with a reference to a mutable storage buffer.
     pub fn add_characteristic<T: AsGatt, U: Into<Uuid>>(
         &mut self,
         uuid: U,
@@ -588,7 +588,7 @@ impl<'d, M: RawMutex, const MAX: usize> ServiceBuilder<'_, 'd, M, MAX> {
         )
     }
 
-    /// Add a characteristic to this service with a refererence to an immutable storage buffer.
+    /// Add a characteristic to this service with a reference to an immutable storage buffer.
     pub fn add_characteristic_ro<T: AsGatt, U: Into<Uuid>>(
         &mut self,
         uuid: U,
diff --git a/host/src/attribute_server.rs b/host/src/attribute_server.rs
@@ -253,7 +253,7 @@ pub struct AttributeServer<
 > {
     att_table: AttributeTable<'values, M, ATT_MAX>,
     cccd_tables: CccdTables<M, CCCD_MAX, CONN_MAX>,
-    _p: PhantomData<P>,
+    _p: PhantomData<P>, // please comment on the purpose
 }
 
 pub(crate) mod sealed {
@@ -939,8 +939,9 @@ mod tests {
                 while let Some(att) = it.next() {
                     let handle = att.handle;
                     let uuid = &att.uuid;
+                    // bad format: "last_handle_in_group for 0x{:0>4x?}, 0x{:0>2x?}  0x{:0>2x?}", // "Unknown display hint: '0>4x?'
                     trace!(
-                        "last_handle_in_group for 0x{:0>4x?}, 0x{:0>2x?}  0x{:0>2x?}",
+                        "last_handle_in_group for 0x{:04x}, 0x{:02x}  0x{:02x}", // not sure which is the intended format, here!
                         handle,
                         uuid,
                         att.last_handle_in_group
@@ -981,7 +982,8 @@ mod tests {
                         )
                         .unwrap();
                     let response = &buffer[0..length];
-                    trace!("  0x{:0>2x?}", response);
+                    // bad format: "  0x{:0>2x?}" <-- "unknown display hint"
+                    trace!("  0x{:02x}", response);
                     // It should be a successful response, because the service should be found, this will assert if
                     // we failed to retrieve the third service.
                     assert_eq!(response[0], att::ATT_READ_BY_GROUP_TYPE_RSP);
diff --git a/host/src/channel_manager.rs b/host/src/channel_manager.rs
@@ -474,14 +474,14 @@ impl<'d, P: PacketPool> ChannelManager<'d, P> {
                 let req = ConnParamUpdateReq::from_hci_bytes_complete(data)?;
                 debug!("[l2cap][conn = {:?}] connection param update request: {:?}", conn, req);
                 let interval_min: bt_hci::param::Duration<1_250> = bt_hci::param::Duration::from_u16(req.interval_min);
-                let interva_max: bt_hci::param::Duration<1_250> = bt_hci::param::Duration::from_u16(req.interval_max);
+                let interval_max: bt_hci::param::Duration<1_250> = bt_hci::param::Duration::from_u16(req.interval_max);
                 let timeout: bt_hci::param::Duration<10_000> = bt_hci::param::Duration::from_u16(req.timeout);
                 use embassy_time::Duration;
                 let _ = manager.post_handle_event(
                     conn,
                     ConnectionEvent::RequestConnectionParams {
                         min_connection_interval: Duration::from_micros(interval_min.as_micros()),
-                        max_connection_interval: Duration::from_micros(interval_min.as_micros()),
+                        max_connection_interval: Duration::from_micros(interval_min.as_micros()), // Q: why didn't anything catch 'interva_max' unused? Isn't that worth fixing? 🤨
                         max_latency: req.latency,
                         supervision_timeout: Duration::from_micros(timeout.as_micros()),
                     },
diff --git a/host/src/connection.rs b/host/src/connection.rs
@@ -476,7 +476,7 @@ impl<'stack, P: PacketPool> Connection<'stack, P> {
                     return Err(crate::Error::Disconnected.into());
                 }
                 Err(BleHostError::BleHost(crate::Error::Hci(bt_hci::param::Error::UNSUPPORTED_REMOTE_FEATURE))) => {
-                    // We tried to send the request as a periperhal but the remote central does not support procedure.
+                    // We tried to send the request as a peripheral but the remote central does not support procedure.
                     // Use the L2CAP signaling method below instead.
                     // This code path should never be reached when acting as a central. If a bugged controller implementation
                     // returns this error code we transmit an invalid L2CAP signal which then is rejected by the remote.
diff --git a/host/src/connection_manager.rs b/host/src/connection_manager.rs
@@ -361,7 +361,7 @@ impl<'d, P: PacketPool> ConnectionManager<'d, P> {
                 if r == role {
                     if !peers.is_empty() {
                         for peer in peers.iter() {
-                            // TODO: Accept advertsing peers which use IRK
+                            // TODO: Accept advertising peers which use IRK
                             if storage.peer_addr_kind.unwrap() == peer.0
                                 && storage.peer_identity.unwrap().bd_addr == *peer.1
                             {
diff --git a/host/src/host.rs b/host/src/host.rs
@@ -717,7 +717,7 @@ impl<'d, C: Controller, P: PacketPool> Runner<'d, C, P> {
             + ControllerCmdSync<LeCreateConnCancel>
             + ControllerCmdSync<LeSetScanEnable>
             + ControllerCmdSync<LeSetExtScanEnable>
-            + for<'t> ControllerCmdSync<LeSetAdvEnable>
+            + ControllerCmdSync<LeSetAdvEnable>
             + for<'t> ControllerCmdSync<LeSetExtAdvEnable<'t>>
             + for<'t> ControllerCmdSync<HostNumberOfCompletedPackets<'t>>
             + ControllerCmdSync<LeReadBufferSize>
@@ -741,7 +741,7 @@ impl<'d, C: Controller, P: PacketPool> Runner<'d, C, P> {
             + ControllerCmdSync<HostBufferSize>
             + ControllerCmdAsync<LeConnUpdate>
             + ControllerCmdSync<SetControllerToHostFlowControl>
-            + for<'t> ControllerCmdSync<LeSetAdvEnable>
+            + ControllerCmdSync<LeSetAdvEnable>
             + for<'t> ControllerCmdSync<LeSetExtAdvEnable<'t>>
             + for<'t> ControllerCmdSync<HostNumberOfCompletedPackets<'t>>
             + ControllerCmdSync<LeSetScanEnable>
@@ -1039,7 +1039,7 @@ impl<'d, C: Controller, P: PacketPool> ControlRunner<'d, C, P> {
             + ControllerCmdSync<SetControllerToHostFlowControl>
             + ControllerCmdSync<Reset>
             + ControllerCmdSync<LeCreateConnCancel>
-            + for<'t> ControllerCmdSync<LeSetAdvEnable>
+            + ControllerCmdSync<LeSetAdvEnable>
             + for<'t> ControllerCmdSync<LeSetExtAdvEnable<'t>>
             + ControllerCmdSync<LeSetScanEnable>
             + ControllerCmdSync<LeSetExtScanEnable>
diff --git a/host/src/lib.rs b/host/src/lib.rs
@@ -76,8 +76,6 @@ pub mod prelude {
     pub use bt_hci::transport::SerialTransport;
     pub use bt_hci::uuid::*;
     #[cfg(feature = "derive")]
-    pub use heapless::String as HeaplessString;
-    #[cfg(feature = "derive")]
     pub use trouble_host_macros::*;
 
     pub use super::att::AttErrorCode;
@@ -436,14 +434,14 @@ pub trait Controller:
     + ControllerCmdAsync<LeCreateConn>
     + ControllerCmdSync<LeClearFilterAcceptList>
     + ControllerCmdSync<LeAddDeviceToFilterAcceptList>
-    + for<'t> ControllerCmdSync<LeSetAdvEnable>
+    + ControllerCmdSync<LeSetAdvEnable>
     + for<'t> ControllerCmdSync<LeSetExtAdvEnable<'t>>
     + for<'t> ControllerCmdSync<HostNumberOfCompletedPackets<'t>>
     + ControllerCmdSync<LeReadBufferSize>
-    + for<'t> ControllerCmdSync<LeSetAdvData>
+    + ControllerCmdSync<LeSetAdvData>
     + ControllerCmdSync<LeSetAdvParams>
-    + for<'t> ControllerCmdSync<LeSetAdvEnable>
-    + for<'t> ControllerCmdSync<LeSetScanResponseData>
+    + ControllerCmdSync<LeSetAdvEnable>
+    + ControllerCmdSync<LeSetScanResponseData>
     + ControllerCmdSync<LeLongTermKeyRequestReply>
     + ControllerCmdAsync<LeEnableEncryption>
     + ControllerCmdSync<ReadBdAddr>
@@ -471,14 +469,14 @@ impl<
             + ControllerCmdSync<LeSetExtScanEnable>
             + ControllerCmdSync<LeCreateConnCancel>
             + ControllerCmdAsync<LeCreateConn>
-            + for<'t> ControllerCmdSync<LeSetAdvEnable>
+            + ControllerCmdSync<LeSetAdvEnable>
             + for<'t> ControllerCmdSync<LeSetExtAdvEnable<'t>>
             + for<'t> ControllerCmdSync<HostNumberOfCompletedPackets<'t>>
             + ControllerCmdSync<LeReadBufferSize>
-            + for<'t> ControllerCmdSync<LeSetAdvData>
+            + ControllerCmdSync<LeSetAdvData>
             + ControllerCmdSync<LeSetAdvParams>
-            + for<'t> ControllerCmdSync<LeSetAdvEnable>
-            + for<'t> ControllerCmdSync<LeSetScanResponseData>
+            + ControllerCmdSync<LeSetAdvEnable>
+            + ControllerCmdSync<LeSetScanResponseData>
             + ControllerCmdSync<LeLongTermKeyRequestReply>
             + ControllerCmdAsync<LeEnableEncryption>
             + ControllerCmdSync<ReadBdAddr>,
diff --git a/host/src/packet_pool.rs b/host/src/packet_pool.rs
@@ -59,7 +59,7 @@ impl<const MTU: usize, const N: usize> State<MTU, N> {
 }
 
 /// A packet pool holds a pool of packet buffers that can be dynamically allocated
-/// and free'd.
+/// and freed.
 pub struct StaticPacketPool<M: RawMutex, const MTU: usize, const N: usize> {
     state: Mutex<M, RefCell<State<MTU, N>>>,
 }
diff --git a/host/src/peripheral.rs b/host/src/peripheral.rs
@@ -31,10 +31,10 @@ impl<'d, C: Controller, P: PacketPool> Peripheral<'d, C, P> {
         data: Advertisement<'k>,
     ) -> Result<Advertiser<'d, C, P>, BleHostError<C::Error>>
     where
-        C: for<'t> ControllerCmdSync<LeSetAdvData>
+        C: ControllerCmdSync<LeSetAdvData>
             + ControllerCmdSync<LeSetAdvParams>
-            + for<'t> ControllerCmdSync<LeSetAdvEnable>
-            + for<'t> ControllerCmdSync<LeSetScanResponseData>,
+            + ControllerCmdSync<LeSetAdvEnable>
+            + ControllerCmdSync<LeSetScanResponseData>,
     {
         let host = &self.stack.host;
 
@@ -106,14 +106,14 @@ impl<'d, C: Controller, P: PacketPool> Peripheral<'d, C, P> {
         })
     }
 
-    /// Update the advertisment adv_data and/or scan_data. Does not change any
+    /// Update the advertisement adv_data and/or scan_data. Does not change any
     /// other advertising parameters. If no advertising is active, this will not
     /// produce any observable effect. This is typically useful when
     /// implementing a BLE beacon that only broadcasts advertisement data and
     /// does not accept any connections.
     pub async fn update_adv_data<'k>(&mut self, data: Advertisement<'k>) -> Result<(), BleHostError<C::Error>>
     where
-        C: for<'t> ControllerCmdSync<LeSetAdvData> + for<'t> ControllerCmdSync<LeSetScanResponseData>,
+        C: ControllerCmdSync<LeSetAdvData> + ControllerCmdSync<LeSetScanResponseData>,
     {
         let host = &self.stack.host;
         let data: RawAdvertisement = data.into();
@@ -243,7 +243,7 @@ impl<'d, C: Controller, P: PacketPool> Peripheral<'d, C, P> {
         })
     }
 
-    /// Update the extended advertisment adv_data and/or scan_data for multiple
+    /// Update the extended advertisement adv_data and/or scan_data for multiple
     /// advertising sets. Does not change any other advertising parameters. If
     /// no advertising is active, this will not produce any observable effect.
     /// This is typically useful when implementing a BLE beacon that only
diff --git a/host/src/security_manager/constants.rs b/host/src/security_manager/constants.rs
@@ -3,9 +3,6 @@ use embassy_time::Duration;
 /// 128-bit encryption key size
 pub(crate) const ENCRYPTION_KEY_SIZE_128_BITS: u8 = 128 / 8;
 
-/// Long duration, to disable the timer
-pub(crate) const TIMEOUT_DISABLE: Duration = Duration::from_secs(3600 * 24 * 365 * 10); // ~10 years
-                                                                                        // Workaround for Duration multiplication not being const
 const TIMEOUT_SECS: u64 = 30;
 /// Pairing time-out
 pub(crate) const TIMEOUT: Duration = Duration::from_secs(TIMEOUT_SECS);
diff --git a/host/src/security_manager/mod.rs b/host/src/security_manager/mod.rs
diff --git a/host/src/security_manager/pairing/central.rs b/host/src/security_manager/pairing/central.rs
diff --git a/host/src/security_manager/pairing/mod.rs b/host/src/security_manager/pairing/mod.rs
diff --git a/host/src/security_manager/pairing/peripheral.rs b/host/src/security_manager/pairing/peripheral.rs
diff --git a/host/src/security_manager/types.rs b/host/src/security_manager/types.rs
diff --git a/host/src/types/mod.rs b/host/src/types/mod.rs

Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@ impl Ctxt {`
`31`	`31`	`}`
`32`	`32`	`}`
`33`	`33`
`34`		`- /// Add an error to the context object with a tokenenizable object.`
	`34`	`+ /// Add an error to the context object with a tokenizable object.`
`35`	`35`	`///`
`36`	`36`	`/// The object is used for spanning in error messages.`
`37`	`37`	`pub fn error_spanned_by<A: ToTokens, T: Display>(&self, obj: A, msg: T) {`
Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,7 @@ pub enum TxPower {`
`35`	`35`	`Plus20dBm = 20,`
`36`	`36`	`}`
`37`	`37`
`38`		`-/// Configuriation for a single advertisement set.`
	`38`	`+/// Configuration for a single advertisement set.`
`39`	`39`	`#[derive(Debug, Clone)]`
`40`	`40`	`#[cfg_attr(feature = "defmt", derive(defmt::Format))]`
`41`	`41`	`pub struct AdvertisementSet<'d> {`
Original file line number	Diff line number	Diff line change
`@@ -402,7 +402,7 @@ impl<'d, M: RawMutex, const MAX: usize> AttributeTable<'d, M, MAX> {`
`402`	`402`	`/// The provided data must exactly match the size of the storage for the characteristic,`
`403`	`403`	`/// otherwise this function will panic.`
`404`	`404`	`///`
`405`		`- /// If the characteristic for the handle cannot be found, or the shape of the data does not match the type of the characterstic,`
	`405`	`+ /// If the characteristic for the handle cannot be found, or the shape of the data does not match the type of the characteristic,`
`406`	`406`	`/// an error is returned`
`407`	`407`	`pub fn set<T: AttributeHandle>(&self, attribute_handle: &T, input: &T::Value) -> Result<(), Error> {`
`408`	`408`	`let gatt_value = input.as_gatt();`
`@@ -563,7 +563,7 @@ impl<'d, M: RawMutex, const MAX: usize> ServiceBuilder<'_, 'd, M, MAX> {`
`563`	`563`	`}`
`564`	`564`	`}`
`565`	`565`
`566`		`- /// Add a characteristic to this service with a refererence to a mutable storage buffer.`
	`566`	`+ /// Add a characteristic to this service with a reference to a mutable storage buffer.`
`567`	`567`	`pub fn add_characteristic<T: AsGatt, U: Into<Uuid>>(`
`568`	`568`	`&mut self,`
`569`	`569`	`uuid: U,`
`@@ -588,7 +588,7 @@ impl<'d, M: RawMutex, const MAX: usize> ServiceBuilder<'_, 'd, M, MAX> {`
`588`	`588`	`)`
`589`	`589`	`}`
`590`	`590`
`591`		`- /// Add a characteristic to this service with a refererence to an immutable storage buffer.`
	`591`	`+ /// Add a characteristic to this service with a reference to an immutable storage buffer.`
`592`	`592`	`pub fn add_characteristic_ro<T: AsGatt, U: Into<Uuid>>(`
`593`	`593`	`&mut self,`
`594`	`594`	`uuid: U,`