Retrieve block name once per state

embeddedt · embeddedt · commit 31cc0a0da0db · 2024-03-17T15:55:07.000-04:00
diff --git a/forge/src/main/java/org/embeddedt/modernfix/forge/dynresources/ModelBakeEventHelper.java b/forge/src/main/java/org/embeddedt/modernfix/forge/dynresources/ModelBakeEventHelper.java
@@ -42,8 +42,9 @@ public ModelBakeEventHelper(Map<ResourceLocation, BakedModel> modelRegistry) {
         this.topLevelModelLocations = new HashSet<>(modelRegistry.keySet());
         // Skip going through ModelLocationCache because most of the accesses will be misses
         for(Block block : ForgeRegistries.BLOCKS) {
+            ResourceLocation name = block.delegate.name();
             for(BlockState state : block.getStateDefinition().getPossibleStates()) {
-                topLevelModelLocations.add(BlockModelShaper.stateToModelLocation(state));
+                topLevelModelLocations.add(BlockModelShaper.stateToModelLocation(name, state));
             }
         }
         ForgeRegistries.ITEMS.getKeys().forEach(key -> topLevelModelLocations.add(new ModelResourceLocation(key, "inventory")));

Original file line number	Diff line number	Diff line change
`@@ -42,8 +42,9 @@ public ModelBakeEventHelper(Map<ResourceLocation, BakedModel> modelRegistry) {`
`42`	`42`	`this.topLevelModelLocations = new HashSet<>(modelRegistry.keySet());`
`43`	`43`	`// Skip going through ModelLocationCache because most of the accesses will be misses`
`44`	`44`	`for(Block block : ForgeRegistries.BLOCKS) {`
	`45`	`+ ResourceLocation name = block.delegate.name();`
`45`	`46`	`for(BlockState state : block.getStateDefinition().getPossibleStates()) {`
`46`		`- topLevelModelLocations.add(BlockModelShaper.stateToModelLocation(state));`
	`47`	`+ topLevelModelLocations.add(BlockModelShaper.stateToModelLocation(name, state));`
`47`	`48`	`}`
`48`	`49`	`}`
`49`	`50`	`ForgeRegistries.ITEMS.getKeys().forEach(key -> topLevelModelLocations.add(new ModelResourceLocation(key, "inventory")));`