Skip to content

Commit 44322a7

Browse files
committed
Tweak narrator mixin
1 parent 8d4a7c3 commit 44322a7

File tree

3 files changed

+5
-22
lines changed

3 files changed

+5
-22
lines changed

common/src/main/java/org/embeddedt/modernfix/common/mixin/devenv/NarratorMixin.java

Lines changed: 0 additions & 17 deletions
This file was deleted.

common/src/main/java/org/embeddedt/modernfix/common/mixin/feature/suppress_narrator_stacktrace/GameNarratorMixin.java

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
package org.embeddedt.modernfix.common.mixin.feature.suppress_narrator_stacktrace;
22

3+
import com.llamalad7.mixinextras.injector.wrapoperation.Operation;
4+
import com.llamalad7.mixinextras.injector.wrapoperation.WrapOperation;
35
import com.mojang.text2speech.Narrator;
46
import com.mojang.text2speech.NarratorLinux;
57
import com.mojang.text2speech.OperatingSystem;
@@ -8,17 +10,16 @@
810
import org.embeddedt.modernfix.annotation.ClientOnlyMixin;
911
import org.spongepowered.asm.mixin.Mixin;
1012
import org.spongepowered.asm.mixin.injection.At;
11-
import org.spongepowered.asm.mixin.injection.Redirect;
1213

1314
@ClientOnlyMixin
1415
@Mixin(GameNarrator.class)
1516
public class GameNarratorMixin {
16-
@Redirect(method = "<init>", at = @At(value = "INVOKE", target = "Lcom/mojang/text2speech/Narrator;getNarrator()Lcom/mojang/text2speech/Narrator;"))
17-
private Narrator suppressStacktracePrinting() {
17+
@WrapOperation(method = "<init>", at = @At(value = "INVOKE", target = "Lcom/mojang/text2speech/Narrator;getNarrator()Lcom/mojang/text2speech/Narrator;"))
18+
private Narrator suppressStacktracePrinting(Operation<Narrator> original) {
1819
try {
1920
return switch (OperatingSystem.get()) {
2021
case LINUX -> new NarratorLinux();
21-
default -> Narrator.getNarrator();
22+
default -> original.call();
2223
};
2324
} catch (Narrator.InitializeException e) {
2425
ModernFix.LOGGER.warn("Failed to initialize Linux Narrator. Make sure you have libflite installed!");

common/src/main/java/org/embeddedt/modernfix/core/config/ModernFixEarlyConfig.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -187,7 +187,6 @@ public DefaultSettingMapBuilder put(String key, Boolean value) {
187187
.put("mixin.feature.log_stdout_in_log_files", true)
188188
.put("mixin.devenv", isDevEnv)
189189
.put("mixin.perf.remove_spawn_chunks", isDevEnv)
190-
.put("mixin.feature.suppress_narrator_stacktrace", !isDevEnv) // Not compatible with mixin.devenv
191190
.putConditionally(() -> !isFabric, "mixin.bugfix.fix_config_crashes", true)
192191
.putConditionally(() -> !isFabric, "mixin.bugfix.forge_at_inject_error", true)
193192
.putConditionally(() -> !isFabric, "mixin.feature.registry_event_progress", false)

0 commit comments

Comments
 (0)