Detect Redirector and show warnings

Author: embeddedt

common/src/main/resources/assets/modernfix/lang/en_us.json

@@ -5,7 +5,8 @@
   "modernfix.no_lazydfu": "LazyDFU is not installed. If Minecraft needs to update game data from an older version, there may be noticeable lag.",
   "modernfix.no_ferritecore": "FerriteCore is not installed. Memory usage will be very high.",
   "modernfix.connectedness_dynresoruces": "Connectedness and ModernFix's dynamic resources option are not compatible. Remove Connectedness or disable dynamic resources in the ModernFix config.",
-  "modernfix.perf_mod_warning": "It is recommended to install the mods, but the warning(s) can be disabled in the ModernFix config.",
+  "modernfix.perf_mod_warning": "ModernFix mod warnings can be disabled by turning off mixin.feature.warn_missing_perf_mods in the ModernFix config.",
+  "modernfix.redirector_installed": "ModernFix detected that Redirector is installed. Redirector is known to cause many strange and hard-to-debug issues, and removing it is strongly recommended.",
   "modernfix.config": "ModernFix mixin config",
   "modernfix.config.done_restart": "Done (restart required)",
   "modernfix.config.wiki": "Open wiki",

forge/src/main/java/org/embeddedt/modernfix/forge/init/ModernFixForge.java

@@ -24,6 +24,7 @@
 import net.minecraftforge.registries.RegisterEvent;
 import net.minecraftforge.server.ServerLifecycleHooks;
 import org.apache.commons.lang3.tuple.Pair;
+import org.apache.maven.artifact.versioning.DefaultArtifactVersion;
 import org.embeddedt.modernfix.ModernFix;
 import org.embeddedt.modernfix.core.ModernFixMixinPlugin;
 import org.embeddedt.modernfix.entity.EntityDataIDSyncHandler;
@@ -89,6 +90,28 @@ private void registerItems(RegisterEvent event) {
             Pair.of(ImmutableList.of("ferritecore"), "modernfix.no_ferritecore")
     );
 
+    /**
+     * Redirector 5.0 redirects ALL Enum.values() calls to use a cached array, which breaks any code that mutates
+     * the given array, and causes all sorts of impossible to debug issues in mods. We complain loudly when it is
+     * installed now.
+     */
+    private static boolean hasDangerousRedirectorInstalled() {
+        try {
+            var clz = Class.forName("com.teampotato.redirector.RedirectorLaunchPluginService");
+            var pkg = clz.getPackage();
+            if (pkg != null) {
+                String implVer = pkg.getImplementationVersion();
+                var artifactVer = new DefaultArtifactVersion(implVer);
+                return artifactVer.getMajorVersion() == 5;
+            }
+        } catch(Exception e) {
+            if (!(e instanceof ClassNotFoundException)) {
+                ModernFix.LOGGER.error("Error detecting Redirector", e);
+            }
+        }
+        return false;
+    }
+
     @SubscribeEvent
     public void commonSetup(FMLCommonSetupEvent event) {
         if(ModernFixMixinPlugin.instance.isOptionEnabled("feature.warn_missing_perf_mods.Warnings")) {
@@ -101,6 +124,11 @@ public void commonSetup(FMLCommonSetupEvent event) {
                         ModLoader.get().addWarning(new ModLoadingWarning(ModLoadingContext.get().getActiveContainer().getModInfo(), ModLoadingStage.COMMON_SETUP, warning.getRight()));
                     }
                 }
+                if (hasDangerousRedirectorInstalled()) {
+                    ModernFix.LOGGER.fatal("Redirector 5.x is detected, it is known to cause extremely hard-to-debug issues in other mods");
+                    ModLoader.get().addWarning(new ModLoadingWarning(ModLoadingContext.get().getActiveContainer().getModInfo(), ModLoadingStage.COMMON_SETUP, "modernfix.redirector_installed"));
+                    atLeastOneWarning = true;
+                }
                 if(atLeastOneWarning)
                     ModLoader.get().addWarning(new ModLoadingWarning(ModLoadingContext.get().getActiveContainer().getModInfo(), ModLoadingStage.COMMON_SETUP, "modernfix.perf_mod_warning"));
             });