Collect JEI ingredients to list first to avoid concurrency issues

embeddedt · embeddedt · commit 66ef30449a84 · 2024-07-17T18:45:53.000-04:00
diff --git a/common/src/main/java/org/embeddedt/modernfix/searchtree/JEIBackedSearchTree.java b/common/src/main/java/org/embeddedt/modernfix/searchtree/JEIBackedSearchTree.java
@@ -80,7 +80,7 @@ private List<ItemStack> searchJEI(IngredientFilter filter, String pSearchText) {
                 ModernFix.LOGGER.error("Error searching", e);
                 ingredients = Stream.empty();
             }
-            ingredients.forEach(ingredient -> {
+            ingredients.toList().forEach(ingredient -> {
                 if(ingredient.getIngredient() instanceof ItemStack) {
                     listCache.add((ItemStack)ingredient.getIngredient());
                 }

Original file line number	Diff line number	Diff line change
`@@ -80,7 +80,7 @@ private List<ItemStack> searchJEI(IngredientFilter filter, String pSearchText) {`
`80`	`80`	`ModernFix.LOGGER.error("Error searching", e);`
`81`	`81`	`ingredients = Stream.empty();`
`82`	`82`	`}`
`83`		`- ingredients.forEach(ingredient -> {`
	`83`	`+ ingredients.toList().forEach(ingredient -> {`
`84`	`84`	`if(ingredient.getIngredient() instanceof ItemStack) {`
`85`	`85`	`listCache.add((ItemStack)ingredient.getIngredient());`
`86`	`86`	`}`