Skip to content

Commit 6740857

Browse files
committed
Fix unsanitized input being passed to TinyFD
1 parent 9f040b2 commit 6740857

File tree

1 file changed

+18
-0
lines changed

1 file changed

+18
-0
lines changed
Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
package org.embeddedt.modernfix.forge.mixin.bugfix.file_dialog_title;
2+
3+
import net.minecraft.client.gui.screens.worldselection.WorldGenSettingsComponent;
4+
import org.spongepowered.asm.mixin.Mixin;
5+
import org.spongepowered.asm.mixin.injection.At;
6+
import org.spongepowered.asm.mixin.injection.ModifyArg;
7+
8+
@Mixin(WorldGenSettingsComponent.class)
9+
public class WorldGenSettingsComponentMixin {
10+
/**
11+
* @author embeddedt
12+
* @reason Do not provide resource pack-controlled string to TinyFD
13+
*/
14+
@ModifyArg(method = "*", at = @At(value = "INVOKE", target = "Lorg/lwjgl/util/tinyfd/TinyFileDialogs;tinyfd_openFileDialog(Ljava/lang/CharSequence;Ljava/lang/CharSequence;Lorg/lwjgl/PointerBuffer;Ljava/lang/CharSequence;Z)Ljava/lang/String;", remap = false), index = 0)
15+
private CharSequence sanitizeTitleString(CharSequence original) {
16+
return "Select settings file (.json)";
17+
}
18+
}

0 commit comments

Comments
 (0)