Skip to content

Commit f8a35c5

Browse files
committed
Merge 1.19.2 into 1.19.4
2 parents e827fba + 0b685d8 commit f8a35c5

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

common/src/main/java/org/embeddedt/modernfix/common/mixin/perf/faster_item_rendering/ItemRendererMixin.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,13 @@
2323
public abstract class ItemRendererMixin {
2424
private ItemDisplayContext transformType;
2525
private final SimpleItemModelView modelView = new SimpleItemModelView();
26+
private boolean mfix$isTopLevelSimpleModel;
2627

2728
@Inject(method = "render", at = @At("HEAD"))
2829
private void markRenderingType(ItemStack itemStack, ItemDisplayContext transformType, boolean leftHand, PoseStack matrixStack, MultiBufferSource buffer, int combinedLight, int combinedOverlay, BakedModel model, CallbackInfo ci) {
2930
this.transformType = transformType;
31+
// used as renderModelLists may be called by custom model renderers
32+
this.mfix$isTopLevelSimpleModel = model != null && model.getClass() == SimpleBakedModel.class;
3033
}
3134

3235
/**
@@ -39,7 +42,7 @@ private void markRenderingType(ItemStack itemStack, ItemDisplayContext transform
3942
*/
4043
@ModifyVariable(method = "renderModelLists", at = @At("HEAD"), index = 1, argsOnly = true)
4144
private BakedModel useSimpleWrappedItemModel(BakedModel model, BakedModel arg, ItemStack stack, int combinedLight, int combinedOverlay, PoseStack matrixStack, VertexConsumer buffer) {
42-
if(!RenderState.IS_RENDERING_LEVEL && !stack.isEmpty() && model.getClass() == SimpleBakedModel.class && transformType == ItemDisplayContext.GUI) {
45+
if(!RenderState.IS_RENDERING_LEVEL && !stack.isEmpty() && mfix$isTopLevelSimpleModel && model.getClass() == SimpleBakedModel.class && transformType == ItemDisplayContext.GUI) {
4346
FastItemRenderType type;
4447
ItemTransform transform = model.getTransforms().gui;
4548
if(transform == ItemTransform.NO_TRANSFORM)

0 commit comments

Comments
 (0)