Skip to content

Commit 52ec861

Browse files
fix: remove n_jobs-1 from logistic regression (#4211)
It is currently ignored and gives a future warning. closes #4210
1 parent 5b8131f commit 52ec861

File tree

4 files changed

+6
-16
lines changed

4 files changed

+6
-16
lines changed

mteb/abstasks/classification.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,6 @@ class AbsTaskClassification(AbsTask):
133133

134134
evaluator: type[SklearnEvaluator] = SklearnEvaluator
135135
evaluator_model: SklearnModelProtocol = LogisticRegression(
136-
n_jobs=-1,
137136
max_iter=100,
138137
)
139138

mteb/abstasks/regression.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ class AbsTaskRegression(AbsTaskClassification):
100100
"""
101101

102102
evaluator: type[SklearnEvaluator] = SklearnEvaluator
103-
evaluator_model: SklearnModelProtocol = LinearRegression(n_jobs=-1)
103+
evaluator_model: SklearnModelProtocol = LinearRegression()
104104

105105
train_split: str = "train"
106106
label_column_name: str = "value"

tests/mock_tasks.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,7 @@ def create_mock_audio(
146146

147147

148148
class MockClassificationTask(AbsTaskClassification):
149-
classifier = LogisticRegression(n_jobs=1, max_iter=10)
149+
classifier = LogisticRegression(max_iter=10)
150150

151151
expected_stats = {
152152
"test": {
@@ -224,7 +224,7 @@ def load_data(self, num_proc: int | None = None, **kwargs) -> None:
224224

225225

226226
class MockMultilingualClassificationTask(AbsTaskClassification):
227-
classifier = LogisticRegression(n_jobs=1, max_iter=10)
227+
classifier = LogisticRegression(max_iter=10)
228228

229229
expected_stats = {
230230
"test": {

tests/test_evaluators/test_ClassificationEvaluator.py

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -33,10 +33,7 @@ def test_expected_scores(model, mock_task):
3333
mock_task.metadata,
3434
hf_split="test",
3535
hf_subset="default",
36-
evaluator_model=LogisticRegression(
37-
n_jobs=-1,
38-
max_iter=10,
39-
),
36+
evaluator_model=LogisticRegression(max_iter=10),
4037
)
4138
y_pred, test_cache = evaluator(model, encode_kwargs={"batch_size": 32})
4239

@@ -77,10 +74,7 @@ def test_cache_usage_binary(model):
7774
mock_task.metadata,
7875
hf_split="test",
7976
hf_subset="default",
80-
evaluator_model=LogisticRegression(
81-
n_jobs=-1,
82-
max_iter=10,
83-
),
77+
evaluator_model=LogisticRegression(max_iter=10),
8478
)
8579
_, test_cache_initial = evaluator_initial(model, encode_kwargs={"batch_size": 32})
8680

@@ -93,10 +87,7 @@ def test_cache_usage_binary(model):
9387
mock_task.metadata,
9488
hf_split="test",
9589
hf_subset="default",
96-
evaluator_model=LogisticRegression(
97-
n_jobs=-1,
98-
max_iter=10,
99-
),
90+
evaluator_model=LogisticRegression(max_iter=10),
10091
)
10192
y_pred, test_cache_after_cache_usage = evaluator_with_cache(
10293
model, encode_kwargs={"batch_size": 32}, test_cache=test_cache_initial

0 commit comments

Comments
 (0)