Skip to content

Commit 0918add

Browse files
committed
Fix links to rule guides
1 parent 14f0612 commit 0918add

File tree

4 files changed

+4
-4
lines changed

4 files changed

+4
-4
lines changed

lib/rules/no-action-cp.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ const isCPGetter = require('../utils/computed-property');
33

44
const SENDERS = ['send', 'sendAction', 'sendEvent', 'Em.sendEvent', 'Ember.sendEvent'];
55

6-
const MESSAGE = 'Do not send events or actions in Computed Properties. This will cause data flow issues in the application, where the accessing of a property causes some side-effect. You should only send actions on behalf of user initiated events. Please see the following guide for more infromation: http://github.com/chadhietala/ember-best-practices/files/guides/no-action-cp.md';
6+
const MESSAGE = 'Do not send events or actions in Computed Properties. This will cause data flow issues in the application, where the accessing of a property causes some side-effect. You should only send actions on behalf of user initiated events. Please see the following guide for more infromation: https://github.com/chadhietala/ember-best-practices/blob/master/guides/rules/no-action-cp.md';
77

88
module.exports = {
99
meta: {

lib/rules/no-attrs.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ function isAttrs(node) {
22
return node.property.name === 'attrs' && node.object.type === 'ThisExpression';
33
}
44

5-
const MESSAGE = 'Do not use this.attrs. Please see the following guide for more infromation: http://github.com/chadhietala/ember-best-practices/files/guides/no-observers.md';
5+
const MESSAGE = 'Do not use this.attrs. Please see the following guide for more infromation: https://github.com/chadhietala/ember-best-practices/blob/master/guides/rules/no-attrs.md';
66

77
module.exports = {
88
meta: {

lib/rules/no-observers.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ function isObserver(node) {
66
|| (callee && callee.name === 'observer');
77
}
88

9-
const MESSAGE = 'Do not use observers. Consider using computed properties instead. Please see following guide for more information: http://github.com/chadhietala/ember-best-practices/files/guides/no-observers.md';
9+
const MESSAGE = 'Do not use observers. Consider using computed properties instead. Please see following guide for more information: https://github.com/chadhietala/ember-best-practices/blob/master/guides/rules/no-observers.md';
1010

1111
module.exports = {
1212
meta: {

lib/rules/require-dependent-keys.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
const MESSAGE = 'Do not use Computed Properties without dependent keys. Please see following guide for more information: http://github.com/chadhietala/ember-best-practices/files/guides/require-dependent-keys.md';
1+
const MESSAGE = 'Do not use Computed Properties without dependent keys. Please see following guide for more information: https://github.com/chadhietala/ember-best-practices/blob/master/guides/rules/require-dependent-keys.md';
22

33
function isMissingDependentKeys(name, node, context) {
44
if (name === 'computed' && node.arguments.length === 1) {

0 commit comments

Comments
 (0)